| Message ID | 20240511134251.313513-1-sui.jingfeng@linux.dev (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: nxp-ptn3460: Remove a small useless code snippet | expand |
Hi Sui, Thank you for the patch. On Sat, May 11, 2024 at 09:42:50PM +0800, Sui Jingfeng wrote: > In ptn3460_bridge_attach(), the check on the existence of bridge->encoder > has already been done in the implementation of drm_bridge_attach(). The > driver won't go further if bridge->encoder is NULL and the driver will quit > even if drm_bridge_attach() fails for some reasons. Thereforei, there is s/Thereforei/Therefore/ > no need to check another time at the later, remove the redundant checking > codes "if (!bridge->encoder) { ... }". > > Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/bridge/nxp-ptn3460.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c > index ed93fd4c3265..e77aab965fcf 100644 > --- a/drivers/gpu/drm/bridge/nxp-ptn3460.c > +++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c > @@ -229,11 +229,6 @@ static int ptn3460_bridge_attach(struct drm_bridge *bridge, > if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) > return 0; > > - if (!bridge->encoder) { > - DRM_ERROR("Parent encoder object not found"); > - return -ENODEV; > - } > - > ptn_bridge->connector.polled = DRM_CONNECTOR_POLL_HPD; > ret = drm_connector_init(bridge->dev, &ptn_bridge->connector, > &ptn3460_connector_funcs, DRM_MODE_CONNECTOR_LVDS);
diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c index ed93fd4c3265..e77aab965fcf 100644 --- a/drivers/gpu/drm/bridge/nxp-ptn3460.c +++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c @@ -229,11 +229,6 @@ static int ptn3460_bridge_attach(struct drm_bridge *bridge, if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) return 0; - if (!bridge->encoder) { - DRM_ERROR("Parent encoder object not found"); - return -ENODEV; - } - ptn_bridge->connector.polled = DRM_CONNECTOR_POLL_HPD; ret = drm_connector_init(bridge->dev, &ptn_bridge->connector, &ptn3460_connector_funcs, DRM_MODE_CONNECTOR_LVDS);
In ptn3460_bridge_attach(), the check on the existence of bridge->encoder has already been done in the implementation of drm_bridge_attach(). The driver won't go further if bridge->encoder is NULL and the driver will quit even if drm_bridge_attach() fails for some reasons. Thereforei, there is no need to check another time at the later, remove the redundant checking codes "if (!bridge->encoder) { ... }". Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev> --- drivers/gpu/drm/bridge/nxp-ptn3460.c | 5 ----- 1 file changed, 5 deletions(-)