| Message ID | 20240516062455.106266-3-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Improve tc358767 debugging | expand |
On Thu, May 16, 2024 at 8:25 AM Alexander Stein <alexander.stein@ew.tq-group.com> wrote: > > Currently the output the following output is printed upon each interrupt: > tc358767 1-000f: GPIO0: > This spams the kernel log while debugging an IRQ storm from the bridge. > Only print the debug output if the GPIO hotplug event actually happened. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > drivers/gpu/drm/bridge/tc358767.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c > index de62a7e2eafec..8874713bdd4a4 100644 > --- a/drivers/gpu/drm/bridge/tc358767.c > +++ b/drivers/gpu/drm/bridge/tc358767.c > @@ -2146,11 +2146,11 @@ static irqreturn_t tc_irq_handler(int irq, void *arg) > bool h = val & INT_GPIO_H(tc->hpd_pin); > bool lc = val & INT_GPIO_LC(tc->hpd_pin); > > - dev_dbg(tc->dev, "GPIO%d: %s %s\n", tc->hpd_pin, > - h ? "H" : "", lc ? "LC" : ""); > - > - if (h || lc) > + if (h || lc) { > + dev_dbg(tc->dev, "GPIO%d: %s %s\n", tc->hpd_pin, > + h ? "H" : "", lc ? "LC" : ""); > drm_kms_helper_hotplug_event(tc->bridge.dev); > + } > } > > regmap_write(tc->regmap, INTSTS_G, val); > -- > 2.34.1 > > Reviewed-by: Robert Foss <rfoss@kernel.org>
diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index de62a7e2eafec..8874713bdd4a4 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -2146,11 +2146,11 @@ static irqreturn_t tc_irq_handler(int irq, void *arg) bool h = val & INT_GPIO_H(tc->hpd_pin); bool lc = val & INT_GPIO_LC(tc->hpd_pin); - dev_dbg(tc->dev, "GPIO%d: %s %s\n", tc->hpd_pin, - h ? "H" : "", lc ? "LC" : ""); - - if (h || lc) + if (h || lc) { + dev_dbg(tc->dev, "GPIO%d: %s %s\n", tc->hpd_pin, + h ? "H" : "", lc ? "LC" : ""); drm_kms_helper_hotplug_event(tc->bridge.dev); + } } regmap_write(tc->regmap, INTSTS_G, val);
Currently the output the following output is printed upon each interrupt: tc358767 1-000f: GPIO0: This spams the kernel log while debugging an IRQ storm from the bridge. Only print the debug output if the GPIO hotplug event actually happened. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- drivers/gpu/drm/bridge/tc358767.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)