| Message ID | 20240405003658.3490494-5-gerickson@nuovations.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC,v8] term: Added 'l_term_*' symbols. | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| prestwoj/iwd-ci-makedistcheck | success | Make Distcheck |
| prestwoj/iwd-ci-build | success | Build - Configure |
| prestwoj/iwd-ci-makecheckvalgrind | success | Make Check w/Valgrind |
| prestwoj/iwd-ci-makecheck | success | Make Check |
| prestwoj/iwd-ci-clang | success | clang PASS |
| prestwoj/iwd-ci-testrunner | success | test-runner PASS |
Hi Grant, On Thu, 2024-04-04 at 17:36 -0700, Grant Erickson wrote: > --- > ell/ell.sym | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/ell/ell.sym b/ell/ell.sym > index 28b55d36719b..2767bf55e079 100644 > --- a/ell/ell.sym > +++ b/ell/ell.sym > @@ -623,6 +623,27 @@ global: > l_ecdh_generate_shared_secret; > /* time */ > l_time_now; > + /* term */ > + l_term_new; > + l_term_free; > + l_term_set_io_handler; > + l_term_set_input; > + l_term_set_input_stdin; > + l_term_set_output; > + l_term_set_output_stdout; > + l_term_set_key_handler; > + l_term_open; > + l_term_close; Didn't you argue / say in the cover letter to v6 that these two functions were renamed to l_term_{acquire,release} ? // Martin > + l_term_io_callback; > + l_term_process; > + l_term_putnstr; > + l_term_putstr; > + l_term_putchar; > + l_term_print; > + l_term_vprint; > + l_term_set_bounds; > + l_term_get_rows; > + l_term_get_columns; > /* gpio */ > l_gpio_chips_with_line_label; > l_gpio_chip_new;
On May 16, 2024, at 1:16 AM, Martin Hundebøll <martin@geanix.com> wrote: > On Thu, 2024-04-04 at 17:36 -0700, Grant Erickson wrote: >> --- >> ell/ell.sym | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/ell/ell.sym b/ell/ell.sym >> index 28b55d36719b..2767bf55e079 100644 >> --- a/ell/ell.sym >> +++ b/ell/ell.sym >> @@ -623,6 +623,27 @@ global: >> l_ecdh_generate_shared_secret; >> /* time */ >> l_time_now; >> + /* term */ >> + l_term_new; >> + l_term_free; >> + l_term_set_io_handler; >> + l_term_set_input; >> + l_term_set_input_stdin; >> + l_term_set_output; >> + l_term_set_output_stdout; >> + l_term_set_key_handler; >> + l_term_open; >> + l_term_close; > > Didn't you argue / say in the cover letter to v6 that these two > functions were renamed to l_term_{acquire,release} ? Martin, Confirmed, you may note "[RFC PATCH v8] ell/edit: Rename 'l_term_{open,close}’.” patch later in that series that performs the rename of those symbols. I intentionally left the revision history intact in the patch set, rather than squashing them, so that it was clear where Marcel started and then the changes I made atop those. Best, Grant
diff --git a/ell/ell.sym b/ell/ell.sym index 28b55d36719b..2767bf55e079 100644 --- a/ell/ell.sym +++ b/ell/ell.sym @@ -623,6 +623,27 @@ global: l_ecdh_generate_shared_secret; /* time */ l_time_now; + /* term */ + l_term_new; + l_term_free; + l_term_set_io_handler; + l_term_set_input; + l_term_set_input_stdin; + l_term_set_output; + l_term_set_output_stdout; + l_term_set_key_handler; + l_term_open; + l_term_close; + l_term_io_callback; + l_term_process; + l_term_putnstr; + l_term_putstr; + l_term_putchar; + l_term_print; + l_term_vprint; + l_term_set_bounds; + l_term_get_rows; + l_term_get_columns; /* gpio */ l_gpio_chips_with_line_label; l_gpio_chip_new;