| Message ID | 20230331113305.77217-1-frank.li@vivo.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [f2fs-dev] f2fs: convert to use sysfs_emit | expand |
On 2023/3/31 19:33, Yangtao Li wrote: > Let's use sysfs_emit. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > fs/f2fs/sysfs.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > index 9ddc6ee19433..2c0b2cb05a3a 100644 > --- a/fs/f2fs/sysfs.c > +++ b/fs/f2fs/sysfs.c > @@ -312,19 +312,13 @@ static ssize_t f2fs_sbi_show(struct f2fs_attr *a, > > if (!strcmp(a->attr.name, "ckpt_thread_ioprio")) { > struct ckpt_req_control *cprc = &sbi->cprc_info; > - int len = 0; > int class = IOPRIO_PRIO_CLASS(cprc->ckpt_thread_ioprio); > int data = IOPRIO_PRIO_DATA(cprc->ckpt_thread_ioprio); > > - if (class == IOPRIO_CLASS_RT) > - len += scnprintf(buf + len, PAGE_SIZE - len, "rt,"); > - else if (class == IOPRIO_CLASS_BE) > - len += scnprintf(buf + len, PAGE_SIZE - len, "be,"); > - else > + if (class != IOPRIO_CLASS_RT && class != IOPRIO_CLASS_BE) > return -EINVAL; > > - len += scnprintf(buf + len, PAGE_SIZE - len, "%d\n", data); > - return len; > + return sysfs_emit(buf, "%s,%d\n", class == IOPRIO_CLASS_RT ? "rt" : "be", data); Exceed 80 columns. Thanks, > } > > #ifdef CONFIG_F2FS_FS_COMPRESSION
On 04/05, Chao Yu wrote: > On 2023/3/31 19:33, Yangtao Li wrote: > > Let's use sysfs_emit. > > > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > > --- > > fs/f2fs/sysfs.c | 10 ++-------- > > 1 file changed, 2 insertions(+), 8 deletions(-) > > > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > > index 9ddc6ee19433..2c0b2cb05a3a 100644 > > --- a/fs/f2fs/sysfs.c > > +++ b/fs/f2fs/sysfs.c > > @@ -312,19 +312,13 @@ static ssize_t f2fs_sbi_show(struct f2fs_attr *a, > > if (!strcmp(a->attr.name, "ckpt_thread_ioprio")) { > > struct ckpt_req_control *cprc = &sbi->cprc_info; > > - int len = 0; > > int class = IOPRIO_PRIO_CLASS(cprc->ckpt_thread_ioprio); > > int data = IOPRIO_PRIO_DATA(cprc->ckpt_thread_ioprio); > > - if (class == IOPRIO_CLASS_RT) > > - len += scnprintf(buf + len, PAGE_SIZE - len, "rt,"); > > - else if (class == IOPRIO_CLASS_BE) > > - len += scnprintf(buf + len, PAGE_SIZE - len, "be,"); > > - else > > + if (class != IOPRIO_CLASS_RT && class != IOPRIO_CLASS_BE) > > return -EINVAL; > > - len += scnprintf(buf + len, PAGE_SIZE - len, "%d\n", data); > > - return len; > > + return sysfs_emit(buf, "%s,%d\n", class == IOPRIO_CLASS_RT ? "rt" : "be", data); > > Exceed 80 columns. Fixed and applied. > > Thanks, > > > } > > #ifdef CONFIG_F2FS_FS_COMPRESSION
On 2023/4/5 23:57, Jaegeuk Kim wrote: > On 04/05, Chao Yu wrote: >> On 2023/3/31 19:33, Yangtao Li wrote: >>> Let's use sysfs_emit. >>> >>> Signed-off-by: Yangtao Li <frank.li@vivo.com> >>> --- >>> fs/f2fs/sysfs.c | 10 ++-------- >>> 1 file changed, 2 insertions(+), 8 deletions(-) >>> >>> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c >>> index 9ddc6ee19433..2c0b2cb05a3a 100644 >>> --- a/fs/f2fs/sysfs.c >>> +++ b/fs/f2fs/sysfs.c >>> @@ -312,19 +312,13 @@ static ssize_t f2fs_sbi_show(struct f2fs_attr *a, >>> if (!strcmp(a->attr.name, "ckpt_thread_ioprio")) { >>> struct ckpt_req_control *cprc = &sbi->cprc_info; >>> - int len = 0; >>> int class = IOPRIO_PRIO_CLASS(cprc->ckpt_thread_ioprio); >>> int data = IOPRIO_PRIO_DATA(cprc->ckpt_thread_ioprio); >>> - if (class == IOPRIO_CLASS_RT) >>> - len += scnprintf(buf + len, PAGE_SIZE - len, "rt,"); >>> - else if (class == IOPRIO_CLASS_BE) >>> - len += scnprintf(buf + len, PAGE_SIZE - len, "be,"); >>> - else >>> + if (class != IOPRIO_CLASS_RT && class != IOPRIO_CLASS_BE) >>> return -EINVAL; >>> - len += scnprintf(buf + len, PAGE_SIZE - len, "%d\n", data); >>> - return len; >>> + return sysfs_emit(buf, "%s,%d\n", class == IOPRIO_CLASS_RT ? "rt" : "be", data); >> >> Exceed 80 columns. > > Fixed and applied. Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index 9ddc6ee19433..2c0b2cb05a3a 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -312,19 +312,13 @@ static ssize_t f2fs_sbi_show(struct f2fs_attr *a, if (!strcmp(a->attr.name, "ckpt_thread_ioprio")) { struct ckpt_req_control *cprc = &sbi->cprc_info; - int len = 0; int class = IOPRIO_PRIO_CLASS(cprc->ckpt_thread_ioprio); int data = IOPRIO_PRIO_DATA(cprc->ckpt_thread_ioprio); - if (class == IOPRIO_CLASS_RT) - len += scnprintf(buf + len, PAGE_SIZE - len, "rt,"); - else if (class == IOPRIO_CLASS_BE) - len += scnprintf(buf + len, PAGE_SIZE - len, "be,"); - else + if (class != IOPRIO_CLASS_RT && class != IOPRIO_CLASS_BE) return -EINVAL; - len += scnprintf(buf + len, PAGE_SIZE - len, "%d\n", data); - return len; + return sysfs_emit(buf, "%s,%d\n", class == IOPRIO_CLASS_RT ? "rt" : "be", data); } #ifdef CONFIG_F2FS_FS_COMPRESSION
Let's use sysfs_emit. Signed-off-by: Yangtao Li <frank.li@vivo.com> --- fs/f2fs/sysfs.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)