diff mbox series

[kvm-unit-tests] Fix check-kerneldoc for out of tree builds

Message ID 20240503053612.970770-1-npiggin@gmail.com (mailing list archive)
State New
Headers show
Series [kvm-unit-tests] Fix check-kerneldoc for out of tree builds | expand

Commit Message

Nicholas Piggin May 3, 2024, 5:36 a.m. UTC
Search the source path rather than cwd.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
I leave ctags and cscope targets not working, since I don't use those
tools and so don't have a test at hand. Being dev tools maybe(?) they
would only get used in the source directory anyway, whereas check
targets are useful for CI, etc.

It should be trivial to fix them up if we want though.

Thanks,
Nick
---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Huth May 3, 2024, 6:29 a.m. UTC | #1
On 03/05/2024 07.36, Nicholas Piggin wrote:
> Search the source path rather than cwd.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> I leave ctags and cscope targets not working, since I don't use those
> tools and so don't have a test at hand. Being dev tools maybe(?) they
> would only get used in the source directory anyway, whereas check
> targets are useful for CI, etc.
> 
> It should be trivial to fix them up if we want though.
> 
> Thanks,
> Nick
> ---
> 
>   Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index b0f7ad08b..5b7998b79 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -150,4 +150,4 @@ tags:
>   	ctags -R
>   
>   check-kerneldoc:
> -	find . -name '*.[ch]' -exec scripts/kernel-doc -none {} +
> +	find $(SRCDIR) -name '*.[ch]' -exec scripts/kernel-doc -none {} +

Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index b0f7ad08b..5b7998b79 100644
--- a/Makefile
+++ b/Makefile
@@ -150,4 +150,4 @@  tags:
 	ctags -R
 
 check-kerneldoc:
-	find . -name '*.[ch]' -exec scripts/kernel-doc -none {} +
+	find $(SRCDIR) -name '*.[ch]' -exec scripts/kernel-doc -none {} +