Message ID | 20231023-display-support-v3-13-53388f3ed34b@baylibre.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B63BC4345F for <linux-arm-kernel@archiver.kernel.org>; Thu, 18 Apr 2024 14:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JWhNuhC+Up/CQngHgz6h1Gqkc+W955s/iDmNl8VFQ7A=; b=0rNucpAAYUqkQw HzQDXsFharK4iNVqGpAS85AS8tWc8hqkY672G6iK5QkTY1lJxyBf1cs3LA7cTnmUhznplkMWwidZO 2J7Okipkz9psn9C8C0sgqbd215AY9Tz61TmvYPqSDK+bapFxQQlULT4mIS1sPr6+CISxVnXzGl8Ci oyd5vqUkEOIDOgy0q6nrwoc1HfbYkG3bc9gtIxex8Ph+nocGHvjdLGAbQcCqAJGZK+647ZUSArtJV PkZb0ZDKoPeLRFTvI8q2L0dt+jeWQ9+EqcCfbrQ4SvCKuw5KUJbp2iNR/9JDMseO7cr2XKgfiq6F7 3DERNiUww6MObmeuBYcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxSbx-00000002ZxJ-07DQ; Thu, 18 Apr 2024 14:19:37 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxSaC-00000002YsH-08Sj for linux-arm-kernel@bombadil.infradead.org; Thu, 18 Apr 2024 14:17:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=hFmw2QUwgoo6nZ5hxL4W4XLY0gvCpX+AxZ6V2ssaQtQ=; b=Z4jOqKyZkxanga51CXtFnlj2zt 7ihajRYxEk04iiJYh5Rg6Wd1HaF6sbq0i1tu6V/Ghy85Z2q9ObfGrN/EhfKtGdC3n598FVoLHGZm8 +7uaZQQOzEdN5NEk0ppAt1zUZPBSDHJGgZsO8rjP9zL/aTpKXyKmF9ibddEJw0UX54s2z3T2xmgFV hVS1j8FW3+P91wQVvHY4cuVFfu5Azqep5tPn8HWotyTcC12ZDHQG92zUychVIO8OmWeVp/Kde3kc0 +pios4HlZMiKxFoVrQ1bcJ9r370kyvU5e4PA1+ohkC4PGmVEgBKM4anH/3ubNBLNeWcsdcA395MCC zdEKTpIw==; Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxSZx-0000000C29f-0p4d for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2024 14:17:46 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-418def30e50so5734595e9.1 for <linux-arm-kernel@lists.infradead.org>; Thu, 18 Apr 2024 07:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1713449851; x=1714054651; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hFmw2QUwgoo6nZ5hxL4W4XLY0gvCpX+AxZ6V2ssaQtQ=; b=lERMhsPkGzEAmDymkxW3lIyo5QPYrXyYoB6hNtxs1wsIOFiI8UToS0qrQW08TZ2ztu dDJgSQxvNcdZqeVABUd9hZkXDJaMzhz2W+ZCDwDzuRYWChKjYesB05lKWi7bm0xrdNd3 vR/NdomPTNanzVdQWAEMdeDkeqn38DV95FIOx6aTVwSHFP4icFrGAi5hqn50eyv5avGA 4+ZXY9vSLigNC052agoiocwvYUmfaHLWVs6U3ZZzTbSMwnsLa6T+ZUm6Zn/1LL+RtOxe CN8itw/TTK5n9LMynHBCTmUuX+AtIxOwFQYtvRz15c7zpok3/dvyOEBQN/Nb+zuP+cWm rHdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713449851; x=1714054651; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hFmw2QUwgoo6nZ5hxL4W4XLY0gvCpX+AxZ6V2ssaQtQ=; b=GRCXR1tqSc35goipiN7HhvwPBZnMEgHh20b+4rz7fzYny6IUZ9cc62Goesra0ecOmo 9NoysRt/Oi9YhDyFGBcpCyzMB+SMzpPhKGUbbtRfTq1cdrZraewwulskWoL9AUM3eR/r 176ZjluEq0rb0E2T76RMgIZL5OMBxuYSe1ASGU5gc/cQyJ25TnEctuiAT29NAIOwrD/q oNpJPYXHyyag5aHpxCdG3pLVD9H87mVU6v+g9+1BKEioIlU0aoR6bA5uHW00G8VXghWV axg+DhB1YACuR/lH4IWy4p90X/OWlOd/63Y1IQTAwVPTeCrLs9Xcmx7fg8A26FuKty0M hO6A== X-Forwarded-Encrypted: i=1; AJvYcCVR0oFSXkOn4ykZ/82XOzx5NIS/F3TQ9zfdbmGzrYgjpgN1SO3z5EkbJDuI4kDvH60gmqsEGhDrBCvkUyJxXdbJ5leAVLF+LO5gZ7wG8o6hUo3hAZE= X-Gm-Message-State: AOJu0YyJrC2WE/Cz5uW/shk+QX5UqR94VvX99yFhEStcBJNoRXXqbxf4 qzueRVuZ0RlevrGgyXczwCC/nm+EhaljkV71sAx/WDj5DuulL2TNSkiNIsR8owc= X-Google-Smtp-Source: AGHT+IHtNCO0sT/PuF83nF5pCjl0HM21KlAZ3i4WM1ZCheFdqhUBy0/ydJhAL6oh54QPdztAbJgG4Q== X-Received: by 2002:a05:600c:45d0:b0:416:902e:51ac with SMTP id s16-20020a05600c45d000b00416902e51acmr2889189wmo.39.1713449851402; Thu, 18 Apr 2024 07:17:31 -0700 (PDT) Received: from [127.0.1.1] ([93.5.22.158]) by smtp.googlemail.com with ESMTPSA id i9-20020a05600c354900b004180c6a26b4sm6267510wmq.1.2024.04.18.07.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 07:17:30 -0700 (PDT) From: Alexandre Mergnat <amergnat@baylibre.com> Date: Thu, 18 Apr 2024 16:17:01 +0200 Subject: [PATCH v3 13/17] drm/mediatek: dsi: Improves the DSI lane setup robustness MIME-Version: 1.0 Message-Id: <20231023-display-support-v3-13-53388f3ed34b@baylibre.com> References: <20231023-display-support-v3-0-53388f3ed34b@baylibre.com> In-Reply-To: <20231023-display-support-v3-0-53388f3ed34b@baylibre.com> To: Chun-Kuang Hu <chunkuang.hu@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Jitao Shi <jitao.shi@mediatek.com>, CK Hu <ck.hu@mediatek.com>, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Fabien Parent <fparent@baylibre.com>, Markus Schneider-Pargmann <msp@baylibre.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org> Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-clk@vger.kernel.org, Alexandre Mergnat <amergnat@baylibre.com> X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1234; i=amergnat@baylibre.com; h=from:subject:message-id; bh=2MnuLxaHZbaJPVARTKFt1rzwpEZuIuXZwcM1ZfvOkrE=; b=owEBbQKS/ZANAwAKAStGSZ1+MdRFAcsmYgBmIStjyt1Phgb317q5nDWLxlAExPeDpj0mMTjN61F/ BDu61hiJAjMEAAEKAB0WIQQjG17X8+qqcA5g/osrRkmdfjHURQUCZiErYwAKCRArRkmdfjHURaLPEA DD28UlYK6wanAEBb+/8HdIb9cDlvSkVu3mDiWADx1o/swuPpU9jbjySikAfXKlWCxzTgzT6lutDaj4 vIwXpt9XbpZrbPOG+Tget6ptvQdD56G/OEcCbmm1YcvFVbkzXPdJ3vVQFPqVXskpbigxF5lnTntCAa FJQBnbFS30JMcTpBUpIq4SqW3JtxAioMKYcOfbpuv0JJjDgMImsgZ2NqsTPUUgXkgHU9pqUicDNziB tACcMWlHs8PPuZS6x2RqA7e0/EfBHs34gTsyTqkpHBRT73N831a+A5oE9kND+dcMxjwlmefeXMOww6 4gQ1U2T7DSkeS9yTVYR8AsbEM2cBnbhFXUw2c8v3kCwjdrNxllliUSuR1dZnhNMUbd3rmtslBJPuIn PEUcsmJemYKuYCBtvx1P/a46vhGIOLSpJnjVsfnpC7jR7i/JQnirmYHsrdfDs2mG/tXihgWSq+4pMq 7dyFGV0egvh21DBo2c4YFPzgoOhrGzEqsqStXbC4VLcRpewhHVww3ZPEqrx+WEby4Cyxl/W/VCSRnU rYMfrRhVr8zR2tUwjXad+n2EMdD7qeI/xHaJHhfjOEkhi2VDhj0pA9qUpXhWYd4XxabIlQYtF0gP2+ 44HrHaDC6UD1n4NL298nlac7LHpz0tj5kGjXtmURjGBcutBuiak9qpaBctZw== X-Developer-Key: i=amergnat@baylibre.com; a=openpgp; fpr=231B5ED7F3EAAA700E60FE8B2B46499D7E31D445 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240418_151733_469018_CEB2690F X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
Add display support for the MT8365-EVK board
|
expand
|
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 9501f4019199..b3f33d4d3d5c 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -642,6 +642,8 @@ static int mtk_dsi_poweron(struct mtk_dsi *dsi) mtk_dsi_config_vdo_timing(dsi); mtk_dsi_set_interrupt_enable(dsi); + dsi->lanes_ready = false; + return 0; err_disable_engine_clk: clk_disable_unprepare(dsi->engine_clk);
Currently, mtk_dsi_lane_ready (which setup the DSI lane) is triggered before mtk_dsi_poweron. lanes_ready flag toggle to true during mtk_dsi_lane_ready function, and the DSI module is set up during mtk_dsi_poweron. Later, during panel driver init, mtk_dsi_lane_ready is triggered but does nothing because lanes are considered ready. Unfortunately, when the panel driver try to communicate, the DSI returns a timeout. The solution found here is to put lanes_ready flag to false after the DSI module setup into mtk_dsi_poweron to init the DSI lanes after the power / setup of the DSI module. Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ 1 file changed, 2 insertions(+)