| Message ID | 20240508-otter-bringup-v1-1-c807d3d931f6@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | qcom: initial support for the SHIFTphone 8 | expand |
On 08/05/2024 01:28, Caleb Connolly wrote: > The SHIFTphone 8 (codename otter) is a smartphone based on the QCM6490 > SoC. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
> The SHIFTphone 8 (codename otter) is a smartphone based on the QCM6490 > SoC. * I suggest to move the last word into the first text line. * Please add an imperative wording for a better change description. Regards, Markus
On 08/05/2024 09:37, Markus Elfring wrote: >> The SHIFTphone 8 (codename otter) is a smartphone based on the QCM6490 >> SoC. > > * I suggest to move the last word into the first text line. > > * Please add an imperative wording for a better change description. Feel free to ignore all comments from Markus (or implement them - up to you). He is banned from mailing lists and ignored by most of the maintainers. Best regards, Krzysztof
> > > The SHIFTphone 8 (codename otter) is a smartphone based on the QCM6490 > > > SoC. > > > > * I suggest to move the last word into the first text line. > > > > * Please add an imperative wording for a better change description. > > Feel free to ignore all comments from Markus I hope that such a hint can be reconsidered. > (or implement them - up to you). This would be nicer also according to another known information source. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc7#n94 > He is banned from mailing lists This was the case for a while. > and ignored by most of the maintainers. Several contributors occasionally adjust their change tolerance, don't they? Regards, Markus
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 66beaac60e1d..d4b2d39f914e 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -364,8 +364,9 @@ properties: - enum: - fairphone,fp5 - qcom,qcm6490-idp - qcom,qcs6490-rb3gen2 + - shift,otter - const: qcom,qcm6490 - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform items:
The SHIFTphone 8 (codename otter) is a smartphone based on the QCM6490 SoC. Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)