diff mbox series

[v2,2/2] btrfs: make btrfs_finish_ordered_extent() return void

Message ID 0fc7eb82d2d89b607d663de4fadc031c54aab002.1715798440.git.fdmanana@suse.com (mailing list archive)
State New
Headers show
Series btrfs: fix a bug in the direct IO write path for COW writes | expand

Commit Message

Filipe Manana May 15, 2024, 6:51 p.m. UTC 
From: Filipe Manana <fdmanana@suse.com>

Currently btrfs_finish_ordered_extent() returns a boolean indicating if
the ordered extent was added to the work queue for completion, but none
of its callers cares about it, so make it return void.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
 fs/btrfs/ordered-data.c | 3 +--
 fs/btrfs/ordered-data.h | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

Comments

Qu Wenruo May 15, 2024, 10:03 p.m. UTC | #1 
在 2024/5/16 04:21, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
>
> Currently btrfs_finish_ordered_extent() returns a boolean indicating if
> the ordered extent was added to the work queue for completion, but none
> of its callers cares about it, so make it return void.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu
> ---
>   fs/btrfs/ordered-data.c | 3 +--
>   fs/btrfs/ordered-data.h | 2 +-
>   2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c
> index 3a3f21da6eb7..3766804decb8 100644
> --- a/fs/btrfs/ordered-data.c
> +++ b/fs/btrfs/ordered-data.c
> @@ -374,7 +374,7 @@ static void btrfs_queue_ordered_fn(struct btrfs_ordered_extent *ordered)
>   	btrfs_queue_work(wq, &ordered->work);
>   }
>
> -bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
> +void btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
>   				 struct page *page, u64 file_offset, u64 len,
>   				 bool uptodate)
>   {
> @@ -417,7 +417,6 @@ bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
>
>   	if (ret)
>   		btrfs_queue_ordered_fn(ordered);
> -	return ret;
>   }
>
>   /*
> diff --git a/fs/btrfs/ordered-data.h b/fs/btrfs/ordered-data.h
> index b6f6c6b91732..bef22179e7c5 100644
> --- a/fs/btrfs/ordered-data.h
> +++ b/fs/btrfs/ordered-data.h
> @@ -162,7 +162,7 @@ int btrfs_finish_ordered_io(struct btrfs_ordered_extent *ordered_extent);
>   void btrfs_put_ordered_extent(struct btrfs_ordered_extent *entry);
>   void btrfs_remove_ordered_extent(struct btrfs_inode *btrfs_inode,
>   				struct btrfs_ordered_extent *entry);
> -bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
> +void btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
>   				 struct page *page, u64 file_offset, u64 len,
>   				 bool uptodate);
>   void btrfs_mark_ordered_io_finished(struct btrfs_inode *inode,
diff mbox series

Patch

diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c
index 3a3f21da6eb7..3766804decb8 100644
--- a/fs/btrfs/ordered-data.c
+++ b/fs/btrfs/ordered-data.c
@@ -374,7 +374,7 @@  static void btrfs_queue_ordered_fn(struct btrfs_ordered_extent *ordered)
 	btrfs_queue_work(wq, &ordered->work);
 }
 
-bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
+void btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
 				 struct page *page, u64 file_offset, u64 len,
 				 bool uptodate)
 {
@@ -417,7 +417,6 @@  bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
 
 	if (ret)
 		btrfs_queue_ordered_fn(ordered);
-	return ret;
 }
 
 /*
diff --git a/fs/btrfs/ordered-data.h b/fs/btrfs/ordered-data.h
index b6f6c6b91732..bef22179e7c5 100644
--- a/fs/btrfs/ordered-data.h
+++ b/fs/btrfs/ordered-data.h
@@ -162,7 +162,7 @@  int btrfs_finish_ordered_io(struct btrfs_ordered_extent *ordered_extent);
 void btrfs_put_ordered_extent(struct btrfs_ordered_extent *entry);
 void btrfs_remove_ordered_extent(struct btrfs_inode *btrfs_inode,
 				struct btrfs_ordered_extent *entry);
-bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
+void btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
 				 struct page *page, u64 file_offset, u64 len,
 				 bool uptodate);
 void btrfs_mark_ordered_io_finished(struct btrfs_inode *inode,