| Message ID | tencent_FDF9E162435F21368C39AB61255D2F2C8D08@qq.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | staging: fbtft:fixes unnecessary parentheses | expand |
On Sun, Apr 28, 2024 at 08:19:08PM +0800, pipishuo wrote: > This patch fixes the checks reported by checkpatch.pl > for unnecessary parentheses > > Signed-off-by: pipishuo <1289151713@qq.com> > --- > drivers/staging/fbtft/fb_ili9320.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c > index 0be7c2d51548..045275a9bc0b 100644 > --- a/drivers/staging/fbtft/fb_ili9320.c > +++ b/drivers/staging/fbtft/fb_ili9320.c > @@ -37,7 +37,8 @@ static int init_display(struct fbtft_par *par) > devcode = read_devicecode(par); > fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code: 0x%04X\n", > devcode); > - if ((devcode != 0x0000) && (devcode != 0x9320)) > + if (devcode != 0x0000 && > + devcode != 0x9320) Nah, just leave it. It's a personal preference for Greg. https://lore.kernel.org/all/?q=init_display%20devcode regards, dan carpenter
diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c index 0be7c2d51548..045275a9bc0b 100644 --- a/drivers/staging/fbtft/fb_ili9320.c +++ b/drivers/staging/fbtft/fb_ili9320.c @@ -37,7 +37,8 @@ static int init_display(struct fbtft_par *par) devcode = read_devicecode(par); fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code: 0x%04X\n", devcode); - if ((devcode != 0x0000) && (devcode != 0x9320)) + if (devcode != 0x0000 && + devcode != 0x9320) dev_warn(par->info->device, "Unrecognized Device code: 0x%04X (expected 0x9320)\n", devcode);
This patch fixes the checks reported by checkpatch.pl for unnecessary parentheses Signed-off-by: pipishuo <1289151713@qq.com> --- drivers/staging/fbtft/fb_ili9320.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)