Message ID | 20240503-ad9467-fix-scan-type-sign-v1-1-c7a1a066ebb9@baylibre.com (mailing list archive) |
---|---|
State | Accepted |
Headers | show |
Series | iio: adc: ad9467: fix scan type sign | expand |
On Fri, 3 May 2024 14:45:05 -0500 David Lechner <dlechner@baylibre.com> wrote: > According to the IIO documentation, the sign in the scan type should be > lower case. The ad9467 driver was incorrectly using upper case. > > Fix by changing to lower case. > > Fixes: 4606d0f4b05f ("iio: adc: ad9467: add support for AD9434 high-speed ADC") > Fixes: ad6797120238 ("iio: adc: ad9467: add support AD9467 ADC") > Signed-off-by: David Lechner <dlechner@baylibre.com> Applied to the fixes-togreg branch of iio.git. I'll probably sit on this until after the merge window though. Marked for stable. Thanks, Jonathan > --- > drivers/iio/adc/ad9467.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c > index e85b763b9ffc..8f5b9c3f6e3d 100644 > --- a/drivers/iio/adc/ad9467.c > +++ b/drivers/iio/adc/ad9467.c > @@ -243,11 +243,11 @@ static void __ad9467_get_scale(struct ad9467_state *st, int index, > } > > static const struct iio_chan_spec ad9434_channels[] = { > - AD9467_CHAN(0, 0, 12, 'S'), > + AD9467_CHAN(0, 0, 12, 's'), > }; > > static const struct iio_chan_spec ad9467_channels[] = { > - AD9467_CHAN(0, 0, 16, 'S'), > + AD9467_CHAN(0, 0, 16, 's'), > }; > > static const struct ad9467_chip_info ad9467_chip_tbl = { > > --- > base-commit: 827dca3129708a8465bde90c86c2e3c38e62dd4f > change-id: 20240503-ad9467-fix-scan-type-sign-425daca1bb83
diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c index e85b763b9ffc..8f5b9c3f6e3d 100644 --- a/drivers/iio/adc/ad9467.c +++ b/drivers/iio/adc/ad9467.c @@ -243,11 +243,11 @@ static void __ad9467_get_scale(struct ad9467_state *st, int index, } static const struct iio_chan_spec ad9434_channels[] = { - AD9467_CHAN(0, 0, 12, 'S'), + AD9467_CHAN(0, 0, 12, 's'), }; static const struct iio_chan_spec ad9467_channels[] = { - AD9467_CHAN(0, 0, 16, 'S'), + AD9467_CHAN(0, 0, 16, 's'), }; static const struct ad9467_chip_info ad9467_chip_tbl = {
According to the IIO documentation, the sign in the scan type should be lower case. The ad9467 driver was incorrectly using upper case. Fix by changing to lower case. Fixes: 4606d0f4b05f ("iio: adc: ad9467: add support for AD9434 high-speed ADC") Fixes: ad6797120238 ("iio: adc: ad9467: add support AD9467 ADC") Signed-off-by: David Lechner <dlechner@baylibre.com> --- drivers/iio/adc/ad9467.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- base-commit: 827dca3129708a8465bde90c86c2e3c38e62dd4f change-id: 20240503-ad9467-fix-scan-type-sign-425daca1bb83