diff mbox series

dt-bindings: iio: dac: fix ad354xr output range

Message ID 20240503185528.2043127-1-adureghello@baylibre.org (mailing list archive)
State Accepted
Headers show
Series dt-bindings: iio: dac: fix ad354xr output range | expand

Commit Message

Angelo Dureghello May 3, 2024, 6:55 p.m. UTC 
From: Angelo Dureghello <adureghello@baylibre.com>

Fix output range, as per datasheet must be -2.5 to 7.5.

Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
---
 Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Cameron May 4, 2024, 11:30 a.m. UTC | #1 
On Fri,  3 May 2024 20:55:28 +0200
Angelo Dureghello <adureghello@baylibre.com> wrote:

> From: Angelo Dureghello <adureghello@baylibre.com>
> 
> Fix output range, as per datasheet must be -2.5 to 7.5.
> 
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---
When resending to add people and lists to CC, say that somewhere, or just
mark it as a v2 with the change being to increase the cc list.

Otherwise tooling and maintainers can both get confused!

Patch looks fine to me.

Jonathan

>  Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> index 96340a05754c..8265d709094d 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> @@ -139,7 +139,7 @@ allOf:
>                  Voltage output range of the channel as <minimum, maximum>
>                  Required connections:
>                    Rfb1x for: 0 to 2.5 V; 0 to 3V; 0 to 5 V;
> -                  Rfb2x for: 0 to 10 V; 2.5 to 7.5V; -5 to 5 V;
> +                  Rfb2x for: 0 to 10 V; -2.5 to 7.5V; -5 to 5 V;
>                oneOf:
>                  - items:
>                      - const: 0
Krzysztof Kozlowski May 4, 2024, 11:43 a.m. UTC | #2 
On 03/05/2024 20:55, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@baylibre.com>
> 
> Fix output range, as per datasheet must be -2.5 to 7.5.
> 
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---

Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Jonathan Cameron May 5, 2024, 10:04 a.m. UTC | #3 
On Sat, 4 May 2024 13:43:07 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 03/05/2024 20:55, Angelo Dureghello wrote:
> > From: Angelo Dureghello <adureghello@baylibre.com>
> > 
> > Fix output range, as per datasheet must be -2.5 to 7.5.
> > 
> > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> > ---  
> 
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Best regards,
> Krzysztof
> 
I added a fixes tag to the commit that introduced this doc.

Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
index 96340a05754c..8265d709094d 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
@@ -139,7 +139,7 @@  allOf:
                 Voltage output range of the channel as <minimum, maximum>
                 Required connections:
                   Rfb1x for: 0 to 2.5 V; 0 to 3V; 0 to 5 V;
-                  Rfb2x for: 0 to 10 V; 2.5 to 7.5V; -5 to 5 V;
+                  Rfb2x for: 0 to 10 V; -2.5 to 7.5V; -5 to 5 V;
               oneOf:
                 - items:
                     - const: 0