| Message ID | 20240429063847.162247-1-xiaokeqinhealth@126.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/1] mmc: core: increase the timeout period of the ACMD41 command. | expand |
Hello Felix, On 2024-04-29 08:38, Felix Qin wrote: > Extensive testing has shown that some specific SD cards require an > increased command timeout to be successfully initialized. > > More info: > Platform: Rockchip SoC + DW Multimedia host Controller > SD card: Xvv microSD CMH34A17TMA12 (Made in Korea) > Note: The SD card is custom-made by the customer in collaboration > with the wafer foundry. > > Signed-off-by: Felix Qin <xiaokeqinhealth@126.com> > Acked-by: Avri Altman <avri.altman@wdc.com> > Reviewed-by: Dragan Simic <dsimic@manjaro.org> Huh, the v3 looks nowhere like the v2, so please consider my Reviewed-by tag revoked until I get some time to check what actually happened to the patch. > --- > v2: Add more info > v3: Based on the __mmc_poll_for_busy API for modification > --- > drivers/mmc/core/sd_ops.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c > index 3ce1ff336826..a1c028303ba7 100644 > --- a/drivers/mmc/core/sd_ops.c > +++ b/drivers/mmc/core/sd_ops.c > @@ -19,8 +19,13 @@ > #include "sd_ops.h" > #include "mmc_ops.h" > > +/* > + * Extensive testing has shown that some specific SD cards > + * require an increased command timeout to be successfully > + * initialized. > + */ > #define SD_APP_OP_COND_PERIOD_US (10 * 1000) /* 10ms */ > -#define SD_APP_OP_COND_TIMEOUT_MS 1000 /* 1s */ > +#define SD_APP_OP_COND_TIMEOUT_MS 2000 /* 2s */ > > struct sd_app_op_cond_busy_data { > struct mmc_host *host;
Hi Dragan, On 2024/4/29 15:09, Dragan Simic wrote: > Hello Felix, > > On 2024-04-29 08:38, Felix Qin wrote: >> Extensive testing has shown that some specific SD cards require an >> increased command timeout to be successfully initialized. >> >> More info: >> Platform: Rockchip SoC + DW Multimedia host Controller >> SD card: Xvv microSD CMH34A17TMA12 (Made in Korea) >> Note: The SD card is custom-made by the customer in collaboration >> with the wafer foundry. >> >> Signed-off-by: Felix Qin <xiaokeqinhealth@126.com> >> Acked-by: Avri Altman <avri.altman@wdc.com> >> Reviewed-by: Dragan Simic <dsimic@manjaro.org> > > Huh, the v3 looks nowhere like the v2, so please consider > my Reviewed-by tag revoked until I get some time to check what > actually happened to the patch. I apologize for the inconvenience caused, and I will resend the patch. > >> --- >> v2: Add more info >> v3: Based on the __mmc_poll_for_busy API for modification >> --- >> drivers/mmc/core/sd_ops.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c >> index 3ce1ff336826..a1c028303ba7 100644 >> --- a/drivers/mmc/core/sd_ops.c >> +++ b/drivers/mmc/core/sd_ops.c >> @@ -19,8 +19,13 @@ >> #include "sd_ops.h" >> #include "mmc_ops.h" >> >> +/* >> + * Extensive testing has shown that some specific SD cards >> + * require an increased command timeout to be successfully >> + * initialized. >> + */ >> #define SD_APP_OP_COND_PERIOD_US (10 * 1000) /* 10ms */ >> -#define SD_APP_OP_COND_TIMEOUT_MS 1000 /* 1s */ >> +#define SD_APP_OP_COND_TIMEOUT_MS 2000 /* 2s */ >> >> struct sd_app_op_cond_busy_data { >> struct mmc_host *host;
On 2024-04-29 09:19, Yao Xiao wrote: > On 2024/4/29 15:09, Dragan Simic wrote: >> On 2024-04-29 08:38, Felix Qin wrote: >>> Extensive testing has shown that some specific SD cards require an >>> increased command timeout to be successfully initialized. >>> >>> More info: >>> Platform: Rockchip SoC + DW Multimedia host Controller >>> SD card: Xvv microSD CMH34A17TMA12 (Made in Korea) >>> Note: The SD card is custom-made by the customer in collaboration >>> with the wafer foundry. >>> >>> Signed-off-by: Felix Qin <xiaokeqinhealth@126.com> >>> Acked-by: Avri Altman <avri.altman@wdc.com> >>> Reviewed-by: Dragan Simic <dsimic@manjaro.org> >> >> Huh, the v3 looks nowhere like the v2, so please consider >> my Reviewed-by tag revoked until I get some time to check what >> actually happened to the patch. > > I apologize for the inconvenience caused, and I will resend the patch. No worries. I'll go through the v3 and the associated Ulf's patch a bit later. >>> --- >>> v2: Add more info >>> v3: Based on the __mmc_poll_for_busy API for modification >>> --- >>> drivers/mmc/core/sd_ops.c | 7 ++++++- >>> 1 file changed, 6 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c >>> index 3ce1ff336826..a1c028303ba7 100644 >>> --- a/drivers/mmc/core/sd_ops.c >>> +++ b/drivers/mmc/core/sd_ops.c >>> @@ -19,8 +19,13 @@ >>> #include "sd_ops.h" >>> #include "mmc_ops.h" >>> >>> +/* >>> + * Extensive testing has shown that some specific SD cards >>> + * require an increased command timeout to be successfully >>> + * initialized. >>> + */ >>> #define SD_APP_OP_COND_PERIOD_US (10 * 1000) /* 10ms */ >>> -#define SD_APP_OP_COND_TIMEOUT_MS 1000 /* 1s */ >>> +#define SD_APP_OP_COND_TIMEOUT_MS 2000 /* 2s */ >>> >>> struct sd_app_op_cond_busy_data { >>> struct mmc_host *host;
diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c index 3ce1ff336826..a1c028303ba7 100644 --- a/drivers/mmc/core/sd_ops.c +++ b/drivers/mmc/core/sd_ops.c @@ -19,8 +19,13 @@ #include "sd_ops.h" #include "mmc_ops.h" +/* + * Extensive testing has shown that some specific SD cards + * require an increased command timeout to be successfully + * initialized. + */ #define SD_APP_OP_COND_PERIOD_US (10 * 1000) /* 10ms */ -#define SD_APP_OP_COND_TIMEOUT_MS 1000 /* 1s */ +#define SD_APP_OP_COND_TIMEOUT_MS 2000 /* 2s */ struct sd_app_op_cond_busy_data { struct mmc_host *host;