From patchwork Mon May 7 07:42:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 10383409 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CEBEB60159 for ; Mon, 7 May 2018 08:13:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C14322871D for ; Mon, 7 May 2018 08:13:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B59E428721; Mon, 7 May 2018 08:13:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Greylist: delayed 1593 seconds by postgrey-1.34 at pdx-wl-mail.web.codeaurora.org; Mon, 07 May 2018 08:13:54 UTC Received: from web01.groups.io (web01.groups.io [66.175.222.12]) (using TLSv1.2 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5D6C62871D for ; Mon, 7 May 2018 08:13:54 +0000 (UTC) X-Received: from NAM02-BL2-obe.outbound.protection.outlook.com (NAM02-BL2-obe.outbound.protection.outlook.com [104.47.38.68]) by groups.io with SMTP; Mon, 07 May 2018 00:42:54 -0700 X-Received: from xhacker.debian (124.74.246.114) by BN6PR03MB2625.namprd03.prod.outlook.com (2603:10b6:404:59::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.735.17; Mon, 7 May 2018 07:42:50 +0000 Date: Mon, 7 May 2018 15:42:15 +0800 From: Jisheng Zhang To: Neil Armstrong Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-oxnas@groups.io, linux-kernel@vger.kernel.org Subject: [linux-oxnas] [PATCH] arm: oxnas: remove non-necessary flush_cache_all() Message-ID: <20180507154215.45a9348f@xhacker.debian> MIME-Version: 1.0 X-Originating-IP: [124.74.246.114] X-ClientProxiedBy: TYAPR01CA0019.jpnprd01.prod.outlook.com (2603:1096:404::31) To BN6PR03MB2625.namprd03.prod.outlook.com (2603:10b6:404:59::8) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR03MB2625: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 Received-SPF: None (protection.outlook.com: synaptics.com does not designate permitted sender hosts) X-Microsoft-Antispam-Message-Info: bsmIYs0HfiX/rlry33BHGknTw2qP1nmpi1Ccyn0tBfPWT+hUorSm9X/4vFnlOe3ZFpQ5jcDtLbm3bEE3eOd1UpK/rI4cMc5it65z5CDJoft3WcyAhCGMoWRsHYtuACQ+6wsIEdx9EhcU/qG1i+4WHJXcrDXdqP2ruznwdaxTbUrF6E+lhtllViakFBAoPQnP X-MS-Office365-Filtering-Correlation-Id: 0b3b9591-6ad9-47f4-414c-08d5b3ee2397 X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2018 07:42:50.7442 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b3b9591-6ad9-47f4-414c-08d5b3ee2397 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2625 Precedence: Bulk List-Unsubscribe: Sender: linux-oxnas@groups.io List-Id: Mailing-List: list linux-oxnas@groups.io; contact linux-oxnas+owner@groups.io Delivered-To: mailing list linux-oxnas@groups.io Reply-To: linux-oxnas@groups.io,Jisheng.Zhang@synaptics.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1525680834; bh=PLLMmioLTUZgTYucurHLGfO4rOfWWTWol+PbQPUbNd8=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=BeQze8k0OcdvkxkK1NwBTw/ul+kTJJ6rQk06qMbVAdFx7+2GfA1F5uqQWHRHDJ5zMDk fOfa1LroMSisqZ0xrrOPzTxQBuIsIsMpvVSqc5JTRIQJnXDk54BFQpPBYMDx13S1oBNIf i8F4zpdYRtMlM8rSTkTqTHZc6ZmLd2ScmfE= X-Virus-Scanned: ClamAV using ClamSMTP I believe the flush_cache_all() after scu_enable() is to "Ensure that the data accessed by CPU0 before the SCU was initialised is visible to the other CPUs." as commented in scu_enable(). So flush_cache_all() here is a duplication of the one in scu_enable(), remove it. Signed-off-by: Jisheng Zhang --- arch/arm/mach-oxnas/platsmp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-oxnas/platsmp.c b/arch/arm/mach-oxnas/platsmp.c index 442cc8a2f7dc..1a8e1e9fc222 100644 --- a/arch/arm/mach-oxnas/platsmp.c +++ b/arch/arm/mach-oxnas/platsmp.c @@ -85,7 +85,6 @@ static void __init ox820_smp_prepare_cpus(unsigned int max_cpus) goto unmap_scu; scu_enable(scu_base); - flush_cache_all(); unmap_scu: iounmap(scu_base);