| Message ID | 20240425110017.75238-1-joshua.yeong@starfivetech.com (mailing list archive) |
|---|---|
| State | In Next |
| Delegated to: | Rafael Wysocki |
| Headers | show |
| Series | cpufreq: Fix printing large cpu and cpufreq number | expand |
On 25. Apr 2024, at 13:00, Joshua Yeong <joshua.yeong@starfivetech.com> wrote: > > Fix printing negative number when CPU frequency > with large number. > > Signed-off-by: Joshua Yeong <joshua.yeong@starfivetech.com> Reviewed-by: Thorsten Blum <thorsten.blum@toblux.com>
On 25-04-24, 19:00, Joshua Yeong wrote: > Fix printing negative number when CPU frequency > with large number. > > Signed-off-by: Joshua Yeong <joshua.yeong@starfivetech.com> > --- > drivers/cpufreq/freq_table.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c > index c17dc51a5a02..9b9568023f3c 100644 > --- a/drivers/cpufreq/freq_table.c > +++ b/drivers/cpufreq/freq_table.c > @@ -194,7 +194,7 @@ int cpufreq_table_index_unsorted(struct cpufreq_policy *policy, > } > if (optimal.driver_data > i) { > if (suboptimal.driver_data > i) { > - WARN(1, "Invalid frequency table: %d\n", policy->cpu); > + WARN(1, "Invalid frequency table: %u\n", policy->cpu); > return 0; > } > > @@ -254,7 +254,7 @@ static ssize_t show_available_freqs(struct cpufreq_policy *policy, char *buf, > if (show_boost ^ (pos->flags & CPUFREQ_BOOST_FREQ)) > continue; > > - count += sprintf(&buf[count], "%d ", pos->frequency); > + count += sprintf(&buf[count], "%u ", pos->frequency); > } > count += sprintf(&buf[count], "\n"); Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Mon, Apr 29, 2024 at 5:21 AM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > On 25-04-24, 19:00, Joshua Yeong wrote: > > Fix printing negative number when CPU frequency > > with large number. > > > > Signed-off-by: Joshua Yeong <joshua.yeong@starfivetech.com> > > --- > > drivers/cpufreq/freq_table.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c > > index c17dc51a5a02..9b9568023f3c 100644 > > --- a/drivers/cpufreq/freq_table.c > > +++ b/drivers/cpufreq/freq_table.c > > @@ -194,7 +194,7 @@ int cpufreq_table_index_unsorted(struct cpufreq_policy *policy, > > } > > if (optimal.driver_data > i) { > > if (suboptimal.driver_data > i) { > > - WARN(1, "Invalid frequency table: %d\n", policy->cpu); > > + WARN(1, "Invalid frequency table: %u\n", policy->cpu); > > return 0; > > } > > > > @@ -254,7 +254,7 @@ static ssize_t show_available_freqs(struct cpufreq_policy *policy, char *buf, > > if (show_boost ^ (pos->flags & CPUFREQ_BOOST_FREQ)) > > continue; > > > > - count += sprintf(&buf[count], "%d ", pos->frequency); > > + count += sprintf(&buf[count], "%u ", pos->frequency); > > } > > count += sprintf(&buf[count], "\n"); > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > -- Applied as 6.10 material with edited subject and changelog, thanks!
diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c index c17dc51a5a02..9b9568023f3c 100644 --- a/drivers/cpufreq/freq_table.c +++ b/drivers/cpufreq/freq_table.c @@ -194,7 +194,7 @@ int cpufreq_table_index_unsorted(struct cpufreq_policy *policy, } if (optimal.driver_data > i) { if (suboptimal.driver_data > i) { - WARN(1, "Invalid frequency table: %d\n", policy->cpu); + WARN(1, "Invalid frequency table: %u\n", policy->cpu); return 0; } @@ -254,7 +254,7 @@ static ssize_t show_available_freqs(struct cpufreq_policy *policy, char *buf, if (show_boost ^ (pos->flags & CPUFREQ_BOOST_FREQ)) continue; - count += sprintf(&buf[count], "%d ", pos->frequency); + count += sprintf(&buf[count], "%u ", pos->frequency); } count += sprintf(&buf[count], "\n");
Fix printing negative number when CPU frequency with large number. Signed-off-by: Joshua Yeong <joshua.yeong@starfivetech.com> --- drivers/cpufreq/freq_table.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1