| Message ID | 20240429234152.16230-2-ricardo.neri-calderon@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | intel: thermal: hfi: Add debugfs files for tuning | expand |
On Mon, 2024-04-29 at 16:41 -0700, Ricardo Neri wrote: > The name of the constant HFI_UPDATE_INTERVAL is misleading. It is not > a > periodic interval at which HFI updates are processed. It is the delay > in > the processing of an HFI update after the arrival of an HFI > interrupt. > > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> Acked-by: Zhang Rui <rui.zhang@intel.com> -rui > --- > Cc: Len Brown <len.brown@intel.com> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/thermal/intel/intel_hfi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/intel/intel_hfi.c > b/drivers/thermal/intel/intel_hfi.c > index fbc7f0cd83d7..e2b82d71ab6b 100644 > --- a/drivers/thermal/intel/intel_hfi.c > +++ b/drivers/thermal/intel/intel_hfi.c > @@ -166,7 +166,7 @@ static struct hfi_features hfi_features; > static DEFINE_MUTEX(hfi_instance_lock); > > static struct workqueue_struct *hfi_updates_wq; > -#define HFI_UPDATE_INTERVAL HZ > +#define HFI_UPDATE_DELAY HZ > #define HFI_MAX_THERM_NOTIFY_COUNT 16 > > static void get_hfi_caps(struct hfi_instance *hfi_instance, > @@ -322,7 +322,7 @@ void intel_hfi_process_event(__u64 > pkg_therm_status_msr_val) > raw_spin_unlock(&hfi_instance->event_lock); > > queue_delayed_work(hfi_updates_wq, &hfi_instance- > >update_work, > - HFI_UPDATE_INTERVAL); > + HFI_UPDATE_DELAY); > } > > static void init_hfi_cpu_index(struct hfi_cpu_info *info)
diff --git a/drivers/thermal/intel/intel_hfi.c b/drivers/thermal/intel/intel_hfi.c index fbc7f0cd83d7..e2b82d71ab6b 100644 --- a/drivers/thermal/intel/intel_hfi.c +++ b/drivers/thermal/intel/intel_hfi.c @@ -166,7 +166,7 @@ static struct hfi_features hfi_features; static DEFINE_MUTEX(hfi_instance_lock); static struct workqueue_struct *hfi_updates_wq; -#define HFI_UPDATE_INTERVAL HZ +#define HFI_UPDATE_DELAY HZ #define HFI_MAX_THERM_NOTIFY_COUNT 16 static void get_hfi_caps(struct hfi_instance *hfi_instance, @@ -322,7 +322,7 @@ void intel_hfi_process_event(__u64 pkg_therm_status_msr_val) raw_spin_unlock(&hfi_instance->event_lock); queue_delayed_work(hfi_updates_wq, &hfi_instance->update_work, - HFI_UPDATE_INTERVAL); + HFI_UPDATE_DELAY); } static void init_hfi_cpu_index(struct hfi_cpu_info *info)
The name of the constant HFI_UPDATE_INTERVAL is misleading. It is not a periodic interval at which HFI updates are processed. It is the delay in the processing of an HFI update after the arrival of an HFI interrupt. Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> --- Cc: Len Brown <len.brown@intel.com> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> Cc: Zhang Rui <rui.zhang@intel.com> Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/thermal/intel/intel_hfi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)