mbox series

[GIT,PULL] md-6.9 20240305

Message ID 1C22EE73-62D9-43B0-B1A2-2D3B95F774AC@fb.com (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL] md-6.9 20240305 | expand

Pull-request

https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git tags/md-6.9-20240305

Message

Song Liu March 5, 2024, 11:42 p.m. UTC
Hi Jens, 

Please consider pulling the following fixes for md-6.9 on top of your 
for-6.9/block branch. This set fixes two issues:

1. dmraid regression since 6.7 kernels. This issue was initially 
  reported in [1]. This set of fix has been reviewed and tested by
  md and dm folks. 

2. raid5 hang since 6.7 kernel, reported in [2]. We haven't got a 
  better fix for this issue yet. This revert is a workaround. It has
  been applied to 6.7 stable kernels [3], and proved to be affective.
  We will look more into this issue for a better fix. 

Note: Some recent fixes were shipped via the md-6.8 branch, so the 
md-6.9 branch doesn't have all the fixes. I tested that there is no 
conflict between these fixes and those shipped earlier. I run the 
tests with upstream kernel and changes in block tree and md tree 
(v6.8-rc7 + for-6.9/block + md-6.9).

Thanks,
Song


[1] https://lore.kernel.org/linux-raid/e5e8afe2-e9a8-49a2-5ab0-958d4065c55e@redhat.com/
[2] https://lore.kernel.org/linux-raid/20240123005700.9302-1-dan@danm.net/
[3] 87165c64fe1a in linux-6.7.y branch. 


The following changes since commit 268283244c0f018dec8bf4a9c69ce50684561f46:

  nbd: use the atomic queue limits API in nbd_set_size (2024-03-01 09:08:22 -0700)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git tags/md-6.9-20240305

for you to fetch changes up to 3a889fdce7e8927a7d81d11ca3d26608b3be1c31:

  Merge branch 'dmraid-fix-6.9' into md-6.9 (2024-03-05 12:53:55 -0800)

----------------------------------------------------------------
Song Liu (2):
      Revert "Revert "md/raid5: Wait for MD_SB_CHANGE_PENDING in raid5d""
      Merge branch 'dmraid-fix-6.9' into md-6.9

Yu Kuai (9):
      md: don't clear MD_RECOVERY_FROZEN for new dm-raid until resume
      md: export helpers to stop sync_thread
      md: export helper md_is_rdwr()
      md: add a new helper reshape_interrupted()
      dm-raid: really frozen sync_thread during suspend
      md/dm-raid: don't call md_reap_sync_thread() directly
      dm-raid: add a new helper prepare_suspend() in md_personality
      dm-raid456, md/raid456: fix a deadlock for dm-raid456 while io concurrent with reshape
      dm-raid: fix lockdep waring in "pers->hot_add_disk"

 drivers/md/dm-raid.c | 93 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
 drivers/md/md.c      | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------
 drivers/md/md.h      | 38 +++++++++++++++++++++++++++++++++++++-
 drivers/md/raid5.c   | 44 ++++++++++++++++++++++++++++++++++++++++++--
 4 files changed, 208 insertions(+), 40 deletions(-)

Comments

Christoph Hellwig March 6, 2024, 12:30 p.m. UTC | #1
Hi Song,

can you also send the queue limits changes on?  I'd really like to
have all non-scsi queue limits updates in 6.9 and have been working
hard on that.
Jens Axboe March 6, 2024, 3:29 p.m. UTC | #2
On 3/5/24 4:42 PM, Song Liu wrote:
> Hi Jens, 
> 
> Please consider pulling the following fixes for md-6.9 on top of your 
> for-6.9/block branch. This set fixes two issues:
> 
> 1. dmraid regression since 6.7 kernels. This issue was initially 
>   reported in [1]. This set of fix has been reviewed and tested by
>   md and dm folks. 
> 
> 2. raid5 hang since 6.7 kernel, reported in [2]. We haven't got a 
>   better fix for this issue yet. This revert is a workaround. It has
>   been applied to 6.7 stable kernels [3], and proved to be affective.
>   We will look more into this issue for a better fix. 
> 
> Note: Some recent fixes were shipped via the md-6.8 branch, so the 
> md-6.9 branch doesn't have all the fixes. I tested that there is no 
> conflict between these fixes and those shipped earlier. I run the 
> tests with upstream kernel and changes in block tree and md tree 
> (v6.8-rc7 + for-6.9/block + md-6.9).

Pulled, thanks.
Song Liu March 6, 2024, 5:27 p.m. UTC | #3
Hi Christoph,

On Wed, Mar 6, 2024 at 4:30 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> Hi Song,
>
> can you also send the queue limits changes on?  I'd really like to
> have all non-scsi queue limits updates in 6.9 and have been working
> hard on that.

Sure! Here it is.

Jens, could you please also pull the following changes.

This set by Christoph converts md to the atomic queue limits update API.

Thanks,
Song


The following changes since commit 3a889fdce7e8927a7d81d11ca3d26608b3be1c31:

  Merge branch 'dmraid-fix-6.9' into md-6.9 (2024-03-05 12:53:55 -0800)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git
tags/md-6.9-20240306

for you to fetch changes up to dd27a84b06aa9ea6a94b0f3e59dc768f981962e1:

  block: remove disk_stack_limits (2024-03-06 08:59:54 -0800)

----------------------------------------------------------------
Christoph Hellwig (11):
      md: add a mddev_trace_remap helper
      md: add a mddev_add_trace_msg helper
      md: add a mddev_is_dm helper
      md: add queue limit helpers
      md/raid0: use the atomic queue limit update APIs
      md/raid1: use the atomic queue limit update APIs
      md/raid5: use the atomic queue limit update APIs
      md/raid10: use the atomic queue limit update APIs
      md: don't initialize queue limits
      md: remove mddev->queue
      block: remove disk_stack_limits

 block/blk-settings.c   |  24 --------
 drivers/md/md-bitmap.c |   9 +--
 drivers/md/md.c        |  89 +++++++++++++++++++++--------
 drivers/md/md.h        |  28 ++++++++-
 drivers/md/raid0.c     |  42 +++++++-------
 drivers/md/raid1.c     |  51 ++++++++---------
 drivers/md/raid10.c    |  85 ++++++++++++++-------------
 drivers/md/raid5-ppl.c |   3 +-
 drivers/md/raid5.c     | 174
+++++++++++++++++++++++++++-----------------------------
 include/linux/blkdev.h |   2 -
 10 files changed, 265 insertions(+), 242 deletions(-)
Jens Axboe March 6, 2024, 6:16 p.m. UTC | #4
On 3/6/24 10:27 AM, Song Liu wrote:
> Hi Christoph,
> 
> On Wed, Mar 6, 2024 at 4:30?AM Christoph Hellwig <hch@infradead.org> wrote:
>>
>> Hi Song,
>>
>> can you also send the queue limits changes on?  I'd really like to
>> have all non-scsi queue limits updates in 6.9 and have been working
>> hard on that.
> 
> Sure! Here it is.
> 
> Jens, could you please also pull the following changes.
> 
> This set by Christoph converts md to the atomic queue limits update API.

You could've just replied to the thread with "Reviewed-by" like I
suggested, would've saved both of us some time! Anyway, pulled.