| Message ID | 2FCF4E06-B33B-44A8-95D7-8BA481313BB8@fb.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [GIT,PULL] md-6.8 20240305 | expand |
On 3/5/24 11:47 AM, Song Liu wrote: > Hi Jens, > > Please consider pulling the following fixes for md-6.8 on top of your > block-6.8 branch. This set fixes two issues: > > 1. dmraid regression since 6.7 kernels. This issue was initially > reported in [1]. This set of fix has been reviewed and tested by > md and dm folks. > > 2. raid5 hang since 6.7 kernel, reported in [2]. We haven't got a > better fix for this issue yet. This revert is a workaround. It has > been applied to 6.7 stable kernels [3], and proved to be affective. > We will look more into this issue for a better fix. > > We understand this is really last minute for the 6.8 release. But based > on the data we have, these changes are safe and fix issues in the 6.8 > kernel. There's just no way we're doing this much at this late in the process, particularly when these are a) not introduced in the 6.8 cycle, and b) we're not even a week away from the merge window. Doing them now for 6.8 would just further risk stability there, no matter how well it's tested, and it won't really reduce the time to stable anyway. Hence no, please add these to the 6.9 queue.
On Tue, Mar 05 2024 at 1:49P -0500, Jens Axboe <axboe@kernel.dk> wrote: > On 3/5/24 11:47 AM, Song Liu wrote: > > Hi Jens, > > > > Please consider pulling the following fixes for md-6.8 on top of your > > block-6.8 branch. This set fixes two issues: > > > > 1. dmraid regression since 6.7 kernels. This issue was initially > > reported in [1]. This set of fix has been reviewed and tested by > > md and dm folks. > > > > 2. raid5 hang since 6.7 kernel, reported in [2]. We haven't got a > > better fix for this issue yet. This revert is a workaround. It has > > been applied to 6.7 stable kernels [3], and proved to be affective. > > We will look more into this issue for a better fix. > > > > We understand this is really last minute for the 6.8 release. But based > > on the data we have, these changes are safe and fix issues in the 6.8 > > kernel. > > There's just no way we're doing this much at this late in the process, > particularly when these are a) not introduced in the 6.8 cycle, and b) > we're not even a week away from the merge window. Doing them now for 6.8 > would just further risk stability there, no matter how well it's tested, > and it won't really reduce the time to stable anyway. Hence no, please > add these to the 6.9 queue. I agree. Song, please revisit each commit's header to make sure they are flagged for stable@ if appropriate (e.g. either add a Fixes: tag or explicitly Cc: stable@). Thanks, Mike
Hi Jens and Mike, > On Mar 5, 2024, at 11:16 AM, Mike Snitzer <snitzer@kernel.org> wrote: > > On Tue, Mar 05 2024 at 1:49P -0500, > Jens Axboe <axboe@kernel.dk> wrote: > >> On 3/5/24 11:47 AM, Song Liu wrote: >>> Hi Jens, >>> >>> Please consider pulling the following fixes for md-6.8 on top of your >>> block-6.8 branch. This set fixes two issues: >>> >>> 1. dmraid regression since 6.7 kernels. This issue was initially >>> reported in [1]. This set of fix has been reviewed and tested by >>> md and dm folks. >>> >>> 2. raid5 hang since 6.7 kernel, reported in [2]. We haven't got a >>> better fix for this issue yet. This revert is a workaround. It has >>> been applied to 6.7 stable kernels [3], and proved to be affective. >>> We will look more into this issue for a better fix. >>> >>> We understand this is really last minute for the 6.8 release. But based >>> on the data we have, these changes are safe and fix issues in the 6.8 >>> kernel. >> >> There's just no way we're doing this much at this late in the process, >> particularly when these are a) not introduced in the 6.8 cycle, and b) >> we're not even a week away from the merge window. Doing them now for 6.8 >> would just further risk stability there, no matter how well it's tested, >> and it won't really reduce the time to stable anyway. Hence no, please >> add these to the 6.9 queue. > > I agree. > > Song, please revisit each commit's header to make sure they are > flagged for stable@ if appropriate (e.g. either add a Fixes: tag or > explicitly Cc: stable@). Thanks for the suggestions. I will resend them via md-6.9 branch. Song
Hi Jens, Please consider pulling the following fixes for md-6.8 on top of your block-6.8 branch. This set fixes two issues: 1. dmraid regression since 6.7 kernels. This issue was initially reported in [1]. This set of fix has been reviewed and tested by md and dm folks. 2. raid5 hang since 6.7 kernel, reported in [2]. We haven't got a better fix for this issue yet. This revert is a workaround. It has been applied to 6.7 stable kernels [3], and proved to be affective. We will look more into this issue for a better fix. We understand this is really last minute for the 6.8 release. But based on the data we have, these changes are safe and fix issues in the 6.8 kernel. Thanks, Song [1] https://lore.kernel.org/linux-raid/e5e8afe2-e9a8-49a2-5ab0-958d4065c55e@redhat.com/ [2] https://lore.kernel.org/linux-raid/20240123005700.9302-1-dan@danm.net/ [3] 87165c64fe1a in linux-6.7.y branch. The following changes since commit 9e46c70e829bddc24e04f963471e9983a11598b7: md: Don't suspend the array for interrupted reshape (2024-02-15 14:17:27 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git tags/md-6.8-20240305 for you to fetch changes up to c98ebd219303a265cf735f77d70b2f80302dc6d6: Merge branch 'dmraid-fix' into md-6.8 (2024-03-05 10:13:09 -0800) ---------------------------------------------------------------- Song Liu (2): Revert "Revert "md/raid5: Wait for MD_SB_CHANGE_PENDING in raid5d"" Merge branch 'dmraid-fix' into md-6.8 Yu Kuai (9): md: don't clear MD_RECOVERY_FROZEN for new dm-raid until resume md: export helpers to stop sync_thread md: export helper md_is_rdwr() md: add a new helper reshape_interrupted() dm-raid: really frozen sync_thread during suspend md/dm-raid: don't call md_reap_sync_thread() directly dm-raid: add a new helper prepare_suspend() in md_personality dm-raid456, md/raid456: fix a deadlock for dm-raid456 while io concurrent with reshape dm-raid: fix lockdep waring in "pers->hot_add_disk" drivers/md/dm-raid.c | 93 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------- drivers/md/md.c | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------- drivers/md/md.h | 38 +++++++++++++++++++++++++++++++++++++- drivers/md/raid5.c | 44 ++++++++++++++++++++++++++++++++++++++++++-- 4 files changed, 208 insertions(+), 40 deletions(-)