diff mbox series

[v2,1/2] dt-bindings: arm: rockchip: add Radxa ROCK 3C

Message ID 20240428123618.72170-2-amadeus@jmu.edu.cn (mailing list archive)
State New
Headers show
Series arm64: dts: rockchip: Add Radxa ROCK 3C | expand

Commit Message

Chukun Pan April 28, 2024, 12:36 p.m. UTC 
The Radxa ROCK 3C is a similar board to the
Radxa ROCK 3A with the Rockchip RK3566 SoC.
Add devicetree binding documentation for it.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski April 28, 2024, 4:37 p.m. UTC | #1 
On 28/04/2024 14:36, Chukun Pan wrote:
> The Radxa ROCK 3C is a similar board to the
> Radxa ROCK 3A with the Rockchip RK3566 SoC.
> Add devicetree binding documentation for it.

For future:

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1bbbaf81134b..e04c213a0dee 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -799,6 +799,11 @@ properties:
>            - const: radxa,rock3a
>            - const: rockchip,rk3568
>  
> +      - description: Radxa ROCK 3C

There was some big renaming of these boards. I assume you are using
correct naming?

Best regards,
Krzysztof
Dragan Simic April 28, 2024, 9:41 p.m. UTC | #2 
Hello Krzysztof,

On 2024-04-28 18:37, Krzysztof Kozlowski wrote:
> On 28/04/2024 14:36, Chukun Pan wrote:
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml 
>> b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 1bbbaf81134b..e04c213a0dee 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -799,6 +799,11 @@ properties:
>>            - const: radxa,rock3a
>>            - const: rockchip,rk3568
>> 
>> +      - description: Radxa ROCK 3C
> 
> There was some big renaming of these boards. I assume you are using
> correct naming?

I can confirm that the naming above is fine.
Chukun Pan April 30, 2024, 10:36 a.m. UTC | #3 
>> The Radxa ROCK 3C is a similar board to the
>> Radxa ROCK 3A with the Rockchip RK3566 SoC.
>> Add devicetree binding documentation for it.

> For future:
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit)

Should I compress these three lines into two?

> There was some big renaming of these boards. I assume you are using
> correct naming?

According to the link below, the model name is now correct:
https://lore.kernel.org/lkml/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/

Thanks,
Chukun
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 1bbbaf81134b..e04c213a0dee 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -799,6 +799,11 @@  properties:
           - const: radxa,rock3a
           - const: rockchip,rk3568
 
+      - description: Radxa ROCK 3C
+        items:
+          - const: radxa,rock-3c
+          - const: rockchip,rk3566
+
       - description: Radxa ROCK 5A
         items:
           - const: radxa,rock-5a