| Message ID | 20201130124915.7573-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | printk: remove obsolete dead assignment | expand |
On Mon 2020-11-30 13:49:15, Lukas Bulwahn wrote: > Commit 849f3127bb46 ("switch /dev/kmsg to ->write_iter()") refactored > devkmsg_write() and left over a dead assignment on the variable 'len'. > > Hence, make clang-analyzer warns: > > kernel/printk/printk.c:744:4: warning: Value stored to 'len' is never read > [clang-analyzer-deadcode.DeadStores] > len -= endp - line; > ^ > > Simply remove this obsolete dead assignment here. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > --- > applies cleanly on current master and next-20201130 > > Petr, please pick this minor non-urgent clean-up patch. > > kernel/printk/printk.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index f279d4fbd9dd..6e4e38b7cd91 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -741,7 +741,6 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from) > if (LOG_FACILITY(u) != 0) > facility = LOG_FACILITY(u); > endp++; > - len -= endp - line; > line = endp; > } > } Yup, it was used to write the trailing '\0'. But it is done earlier now. So, it is not longer needed. Reviewed-by: Petr Mladek <pmladek@suse.com> Best Regards, Petr PS: I'll give it few days just in case anyone else would want to review it. I'll push it then unless anyone complains. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#214): https://lists.elisa.tech/g/linux-safety/message/214 Mute This Topic: https://lists.elisa.tech/mt/78607109/5278000 Group Owner: linux-safety+owner@lists.elisa.tech Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
On (20/11/30 16:37), Petr Mladek wrote: > On Mon 2020-11-30 13:49:15, Lukas Bulwahn wrote: [..] > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > > index f279d4fbd9dd..6e4e38b7cd91 100644 > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > @@ -741,7 +741,6 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from) > > if (LOG_FACILITY(u) != 0) > > facility = LOG_FACILITY(u); > > endp++; > > - len -= endp - line; > > line = endp; > > } > > } > > Yup, it was used to write the trailing '\0'. But it is done earlier > now. So, it is not longer needed. > > Reviewed-by: Petr Mladek <pmladek@suse.com> > > Best Regards, > Petr > > PS: I'll give it few days just in case anyone else would want to > review it. I'll push it then unless anyone complains. FWIW, looks good to me Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> -ss -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#215): https://lists.elisa.tech/g/linux-safety/message/215 Mute This Topic: https://lists.elisa.tech/mt/78607109/5278000 Group Owner: linux-safety+owner@lists.elisa.tech Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
On Mon 2020-11-30 13:49:15, Lukas Bulwahn wrote: > Commit 849f3127bb46 ("switch /dev/kmsg to ->write_iter()") refactored > devkmsg_write() and left over a dead assignment on the variable 'len'. > > Hence, make clang-analyzer warns: > > kernel/printk/printk.c:744:4: warning: Value stored to 'len' is never read > [clang-analyzer-deadcode.DeadStores] > len -= endp - line; > ^ > > Simply remove this obsolete dead assignment here. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> The patch is committed in printk/linux.git, branch for-5.11. Best Regards, Petr -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#216): https://lists.elisa.tech/g/linux-safety/message/216 Mute This Topic: https://lists.elisa.tech/mt/78607109/5278000 Group Owner: linux-safety+owner@lists.elisa.tech Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index f279d4fbd9dd..6e4e38b7cd91 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -741,7 +741,6 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from) if (LOG_FACILITY(u) != 0) facility = LOG_FACILITY(u); endp++; - len -= endp - line; line = endp; } }
Commit 849f3127bb46 ("switch /dev/kmsg to ->write_iter()") refactored devkmsg_write() and left over a dead assignment on the variable 'len'. Hence, make clang-analyzer warns: kernel/printk/printk.c:744:4: warning: Value stored to 'len' is never read [clang-analyzer-deadcode.DeadStores] len -= endp - line; ^ Simply remove this obsolete dead assignment here. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- applies cleanly on current master and next-20201130 Petr, please pick this minor non-urgent clean-up patch. kernel/printk/printk.c | 1 - 1 file changed, 1 deletion(-)