| Message ID | 20211021174242.20627-1-nghialm78@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] ext4: remove useless resetting io_end_size in mpage_process_page() | expand |
On Thu, Oct 21, 2021 at 7:43 PM Nghia Le <nghialm78@gmail.com> wrote: > > The command "make clang-analyzer" detects dead stores. maybe mention that it detects dead stores in mpage_process_page(). > > Do not reset io_end_size to 0 in the current paths, as the function > exists on those paths wihout further using io_end_sized. just a few typo: s/exists/exits/ s/wihout/without/ s/io_end_sized/io_end_size/ So far it looks good. Can you correct those minor points above and then we should be fine... Lukas > > Signed-off-by: Nghia Le <nghialm78@gmail.com> > --- > fs/ext4/inode.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 0f06305167d5..03efed2ed1ea 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -2260,7 +2260,6 @@ static int mpage_process_page(struct mpage_da_data *mpd, struct page *page, > mpd->map.m_len = 0; > mpd->map.m_flags = 0; > io_end_vec->size += io_end_size; > - io_end_size = 0; > > err = mpage_process_page_bufs(mpd, head, bh, lblk); > if (err > 0) > @@ -2285,7 +2284,6 @@ static int mpage_process_page(struct mpage_da_data *mpd, struct page *page, > } while (lblk++, (bh = bh->b_this_page) != head); > > io_end_vec->size += io_end_size; > - io_end_size = 0; > *map_bh = false; > out: > *m_lblk = lblk; > -- > 2.25.1 >
Hi Lukas, Thanks a lot for your comments, I fixed typos and submitted patch to public mailing list. Best regards, Nghia Le On Mon, Oct 25, 2021 at 10:49 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > On Thu, Oct 21, 2021 at 7:43 PM Nghia Le <nghialm78@gmail.com> wrote: > > > > The command "make clang-analyzer" detects dead stores. > > maybe mention that it detects dead stores in mpage_process_page(). > > > > > Do not reset io_end_size to 0 in the current paths, as the function > > exists on those paths wihout further using io_end_sized. > > just a few typo: > > s/exists/exits/ > s/wihout/without/ > s/io_end_sized/io_end_size/ > > So far it looks good. Can you correct those minor points above and > then we should be fine... > > Lukas > > > > > Signed-off-by: Nghia Le <nghialm78@gmail.com> > > --- > > fs/ext4/inode.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > > index 0f06305167d5..03efed2ed1ea 100644 > > --- a/fs/ext4/inode.c > > +++ b/fs/ext4/inode.c > > @@ -2260,7 +2260,6 @@ static int mpage_process_page(struct mpage_da_data > *mpd, struct page *page, > > mpd->map.m_len = 0; > > mpd->map.m_flags = 0; > > io_end_vec->size += io_end_size; > > - io_end_size = 0; > > > > err = mpage_process_page_bufs(mpd, head, bh, > lblk); > > if (err > 0) > > @@ -2285,7 +2284,6 @@ static int mpage_process_page(struct mpage_da_data > *mpd, struct page *page, > > } while (lblk++, (bh = bh->b_this_page) != head); > > > > io_end_vec->size += io_end_size; > > - io_end_size = 0; > > *map_bh = false; > > out: > > *m_lblk = lblk; > > -- > > 2.25.1 > > >
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 0f06305167d5..03efed2ed1ea 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -2260,7 +2260,6 @@ static int mpage_process_page(struct mpage_da_data *mpd, struct page *page, mpd->map.m_len = 0; mpd->map.m_flags = 0; io_end_vec->size += io_end_size; - io_end_size = 0; err = mpage_process_page_bufs(mpd, head, bh, lblk); if (err > 0) @@ -2285,7 +2284,6 @@ static int mpage_process_page(struct mpage_da_data *mpd, struct page *page, } while (lblk++, (bh = bh->b_this_page) != head); io_end_vec->size += io_end_size; - io_end_size = 0; *map_bh = false; out: *m_lblk = lblk;
The command "make clang-analyzer" detects dead stores. Do not reset io_end_size to 0 in the current paths, as the function exists on those paths wihout further using io_end_sized. Signed-off-by: Nghia Le <nghialm78@gmail.com> --- fs/ext4/inode.c | 2 -- 1 file changed, 2 deletions(-)