diff mbox series

[v2] sh: boot: Add proper forward declarations

Message ID b7ea770a3bf26fb2a5f59f4bb83072b2526f7134.1713959841.git.geert+renesas@glider.be (mailing list archive)
State New
Headers show
Series [v2] sh: boot: Add proper forward declarations | expand

Commit Message

Geert Uytterhoeven April 24, 2024, 11:58 a.m. UTC 
arch/sh/boot/compressed/misc.c:110:6: warning: no previous prototype for ‘ftrace_stub’ [-Wmissing-prototypes]
arch/sh/boot/compressed/misc.c:113:6: warning: no previous prototype for ‘arch_ftrace_ops_list_func’ [-Wmissing-prototypes]
arch/sh/boot/compressed/misc.c:123:6: warning: no previous prototype for ‘decompress_kernel’ [-Wmissing-prototypes]

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This is v2 of "[PATCH 08/20] sh: boot: Add proper forward declarations".
https://lore.kernel.org/r/2614d991c816ece903ef47c715bcc53881d34f3f.1709326528.git.geert+renesas@glider.be

v2:
  - Rebase on top of "sh: boot: Remove sh5 cache handling".
---
 arch/sh/boot/compressed/misc.c | 2 ++
 arch/sh/boot/compressed/misc.h | 9 +++++++++
 2 files changed, 11 insertions(+)
 create mode 100644 arch/sh/boot/compressed/misc.h

Comments

John Paul Adrian Glaubitz May 2, 2024, 7:46 a.m. UTC | #1 
Hi Geert,

On Wed, 2024-04-24 at 13:58 +0200, Geert Uytterhoeven wrote:
> arch/sh/boot/compressed/misc.c:110:6: warning: no previous prototype for ‘ftrace_stub’ [-Wmissing-prototypes]
> arch/sh/boot/compressed/misc.c:113:6: warning: no previous prototype for ‘arch_ftrace_ops_list_func’ [-Wmissing-prototypes]
> arch/sh/boot/compressed/misc.c:123:6: warning: no previous prototype for ‘decompress_kernel’ [-Wmissing-prototypes]
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This is v2 of "[PATCH 08/20] sh: boot: Add proper forward declarations".
> https://lore.kernel.org/r/2614d991c816ece903ef47c715bcc53881d34f3f.1709326528.git.geert+renesas@glider.be
> 
> v2:
>   - Rebase on top of "sh: boot: Remove sh5 cache handling".
> ---
>  arch/sh/boot/compressed/misc.c | 2 ++
>  arch/sh/boot/compressed/misc.h | 9 +++++++++
>  2 files changed, 11 insertions(+)
>  create mode 100644 arch/sh/boot/compressed/misc.h
> 
> diff --git a/arch/sh/boot/compressed/misc.c b/arch/sh/boot/compressed/misc.c
> index 195367d40031f9e9..3690379cc86bd4fe 100644
> --- a/arch/sh/boot/compressed/misc.c
> +++ b/arch/sh/boot/compressed/misc.c
> @@ -16,6 +16,8 @@
>  #include <asm/addrspace.h>
>  #include <asm/page.h>
>  
> +#include "misc.h"
> +
>  /*
>   * gzip declarations
>   */
> diff --git a/arch/sh/boot/compressed/misc.h b/arch/sh/boot/compressed/misc.h
> new file mode 100644
> index 0000000000000000..2b4534faa3052857
> --- /dev/null
> +++ b/arch/sh/boot/compressed/misc.h
> @@ -0,0 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef MISC_H
> +#define MISC_H
> +
> +void arch_ftrace_ops_list_func(void);
> +void decompress_kernel(void);
> +void ftrace_stub(void);
> +
> +#endif /* MISC_H */

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
John Paul Adrian Glaubitz May 2, 2024, 10:33 a.m. UTC | #2 
On Wed, 2024-04-24 at 13:58 +0200, Geert Uytterhoeven wrote:
> arch/sh/boot/compressed/misc.c:110:6: warning: no previous prototype for ‘ftrace_stub’ [-Wmissing-prototypes]
> arch/sh/boot/compressed/misc.c:113:6: warning: no previous prototype for ‘arch_ftrace_ops_list_func’ [-Wmissing-prototypes]
> arch/sh/boot/compressed/misc.c:123:6: warning: no previous prototype for ‘decompress_kernel’ [-Wmissing-prototypes]
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This is v2 of "[PATCH 08/20] sh: boot: Add proper forward declarations".
> https://lore.kernel.org/r/2614d991c816ece903ef47c715bcc53881d34f3f.1709326528.git.geert+renesas@glider.be
> 
> v2:
>   - Rebase on top of "sh: boot: Remove sh5 cache handling".
> ---
>  arch/sh/boot/compressed/misc.c | 2 ++
>  arch/sh/boot/compressed/misc.h | 9 +++++++++
>  2 files changed, 11 insertions(+)
>  create mode 100644 arch/sh/boot/compressed/misc.h
> 
> diff --git a/arch/sh/boot/compressed/misc.c b/arch/sh/boot/compressed/misc.c
> index 195367d40031f9e9..3690379cc86bd4fe 100644
> --- a/arch/sh/boot/compressed/misc.c
> +++ b/arch/sh/boot/compressed/misc.c
> @@ -16,6 +16,8 @@
>  #include <asm/addrspace.h>
>  #include <asm/page.h>
>  
> +#include "misc.h"
> +
>  /*
>   * gzip declarations
>   */
> diff --git a/arch/sh/boot/compressed/misc.h b/arch/sh/boot/compressed/misc.h
> new file mode 100644
> index 0000000000000000..2b4534faa3052857
> --- /dev/null
> +++ b/arch/sh/boot/compressed/misc.h
> @@ -0,0 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef MISC_H
> +#define MISC_H
> +
> +void arch_ftrace_ops_list_func(void);
> +void decompress_kernel(void);
> +void ftrace_stub(void);
> +
> +#endif /* MISC_H */

Applied to my sh-linux tree in the for-next branch.

Thanks,
Adrian
diff mbox series

Patch

diff --git a/arch/sh/boot/compressed/misc.c b/arch/sh/boot/compressed/misc.c
index 195367d40031f9e9..3690379cc86bd4fe 100644
--- a/arch/sh/boot/compressed/misc.c
+++ b/arch/sh/boot/compressed/misc.c
@@ -16,6 +16,8 @@ 
 #include <asm/addrspace.h>
 #include <asm/page.h>
 
+#include "misc.h"
+
 /*
  * gzip declarations
  */
diff --git a/arch/sh/boot/compressed/misc.h b/arch/sh/boot/compressed/misc.h
new file mode 100644
index 0000000000000000..2b4534faa3052857
--- /dev/null
+++ b/arch/sh/boot/compressed/misc.h
@@ -0,0 +1,9 @@ 
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef MISC_H
+#define MISC_H
+
+void arch_ftrace_ops_list_func(void);
+void decompress_kernel(void);
+void ftrace_stub(void);
+
+#endif /* MISC_H */