diff mbox series

[2/7] usb: serial: mos7720: don't advertise PARPORT_MODE_PCSPP

Message ID 20240312055350.205878-2-alexhenrie24@gmail.com (mailing list archive)
State New
Headers show
Series [1/7] docs: driver-api: parport-lowlevel: clarify purpose of PARPORT_MODE_PCSPP | expand

Commit Message

Alex Henrie March 12, 2024, 5:50 a.m. UTC 
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
 drivers/usb/serial/mos7720.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Johan Hovold March 12, 2024, 7:39 a.m. UTC | #1 
On Mon, Mar 11, 2024 at 11:50:27PM -0600, Alex Henrie wrote:

This one and at least one of the later ones are also missing commit
messages. Please fix in a v2.

> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>

Johan
Sudip Mukherjee March 12, 2024, 9:53 a.m. UTC | #2 
On Tue, 12 Mar 2024 at 07:39, Johan Hovold <johan@kernel.org> wrote:
>
> On Mon, Mar 11, 2024 at 11:50:27PM -0600, Alex Henrie wrote:
>
> This one and at least one of the later ones are also missing commit
> messages. Please fix in a v2.

It will be a NACK from me.

This patch and other patches removing PARPORT_MODE_PCSPP will break
userspace code.
On my system, I have:
$ cat /proc/sys/dev/parport/parport0/modes
PCSPP,TRISTATE

If the flag is removed then I will only get "TRISTATE", and if there
is any userspace code which checks for the mode then those
applications will stop working with an error.
Daniel Gimpelevich March 12, 2024, 3:27 p.m. UTC | #3 
On Tue, 2024-03-12 at 09:53 +0000, Sudip Mukherjee wrote:
> On Tue, 12 Mar 2024 at 07:39, Johan Hovold <johan@kernel.org> wrote:
> >
> > On Mon, Mar 11, 2024 at 11:50:27PM -0600, Alex Henrie wrote:
> >
> > This one and at least one of the later ones are also missing commit
> > messages. Please fix in a v2.
> 
> It will be a NACK from me.
> 
> This patch and other patches removing PARPORT_MODE_PCSPP will break
> userspace code.
> On my system, I have:
> $ cat /proc/sys/dev/parport/parport0/modes
> PCSPP,TRISTATE
> 
> If the flag is removed then I will only get "TRISTATE", and if there
> is any userspace code which checks for the mode then those
> applications will stop working with an error.

This patch seems like some sort of backscatter from
https://en.wikipedia.org/wiki/XY_problem issues.
Alex Henrie March 13, 2024, 1:30 a.m. UTC | #4 
On Tue, Mar 12, 2024 at 1:39 AM Johan Hovold <johan@kernel.org> wrote:
>
> On Mon, Mar 11, 2024 at 11:50:27PM -0600, Alex Henrie wrote:
>
> This one and at least one of the later ones are also missing commit
> messages. Please fix in a v2.

Thanks for the feedback. I will send a v2 after the 6.9-rc1 release
and if we decide to keep the first three patches, I will add commit
messages to them.

-Alex
Greg KH March 26, 2024, 9:10 a.m. UTC | #5 
On Mon, Mar 11, 2024 at 11:50:27PM -0600, Alex Henrie wrote:
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  drivers/usb/serial/mos7720.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

For obvious reasons I can't take patches without any changelog text,
sorry.

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
index 23544074eb1c..0e97def80e19 100644
--- a/drivers/usb/serial/mos7720.c
+++ b/drivers/usb/serial/mos7720.c
@@ -589,7 +589,7 @@  static int mos7715_parport_init(struct usb_serial *serial)
 		return -EIO;
 	}
 	mos_parport->pp->private_data = mos_parport;
-	mos_parport->pp->modes = PARPORT_MODE_COMPAT | PARPORT_MODE_PCSPP;
+	mos_parport->pp->modes = PARPORT_MODE_COMPAT;
 	mos_parport->pp->dev = &serial->interface->dev;
 	parport_announce_port(mos_parport->pp);