diff mbox series

thunderbolt: There are only 5 basic router registers in pre-USB4 routers

Message ID 20240419105143.3777873-1-mika.westerberg@linux.intel.com (mailing list archive)
State Accepted
Commit a3ad3a90e0a722d9a50c01cfb40e6cfbb975e529
Headers show
Series thunderbolt: There are only 5 basic router registers in pre-USB4 routers | expand

Commit Message

Mika Westerberg April 19, 2024, 10:51 a.m. UTC
Intel pre-USB4 routers only have ROUTER_CS_0 up to ROUTER_CS_4 and it
immediately follows the TMU router registers. Correct this accordingly.

Reported-by: Rajaram Regupathy <rajaram.regupathy@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/thunderbolt/debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mika Westerberg April 24, 2024, 1 p.m. UTC | #1
On Fri, Apr 19, 2024 at 01:51:43PM +0300, Mika Westerberg wrote:
> Intel pre-USB4 routers only have ROUTER_CS_0 up to ROUTER_CS_4 and it
> immediately follows the TMU router registers. Correct this accordingly.
> 
> Reported-by: Rajaram Regupathy <rajaram.regupathy@intel.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Applied to thunderbolt.git/next.
diff mbox series

Patch

diff --git a/drivers/thunderbolt/debugfs.c b/drivers/thunderbolt/debugfs.c
index e324cd899719..193e9dfc983b 100644
--- a/drivers/thunderbolt/debugfs.c
+++ b/drivers/thunderbolt/debugfs.c
@@ -1346,7 +1346,7 @@  static int switch_basic_regs_show(struct tb_switch *sw, struct seq_file *s)
 	if (tb_switch_is_usb4(sw))
 		dwords = ARRAY_SIZE(data);
 	else
-		dwords = 7;
+		dwords = 5;
 
 	ret = tb_sw_read(sw, data, TB_CFG_SWITCH, 0, dwords);
 	if (ret)