From patchwork Tue Nov 14 21:23:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Greear X-Patchwork-Id: 13455999 X-Patchwork-Delegate: miriam.rachel.korenblit@intel.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F6B9C4332F for ; Tue, 14 Nov 2023 21:23:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234045AbjKNVX0 (ORCPT ); Tue, 14 Nov 2023 16:23:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229569AbjKNVX0 (ORCPT ); Tue, 14 Nov 2023 16:23:26 -0500 Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01EAB9D for ; Tue, 14 Nov 2023 13:23:22 -0800 (PST) X-Virus-Scanned: Proofpoint Essentials engine Received: from mail3.candelatech.com (mail2.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 0C387C006C for ; Tue, 14 Nov 2023 21:23:19 +0000 (UTC) Received: from ben-dt5.candelatech.com (50-251-239-81-static.hfc.comcastbusiness.net [50.251.239.81]) by mail3.candelatech.com (Postfix) with ESMTP id 85DED13C2B0; Tue, 14 Nov 2023 13:23:16 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 85DED13C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1699996996; bh=mYm/aqdpHTXv+pXm7BduLACK4YTqUuJE2+UnYAsTyWE=; h=From:To:Cc:Subject:Date:From; b=eDRfAO1suH/Ohf73yuqyYX9qHAaYadea2b9rrAbRPkDE/yzfqGmyoC+RnNv3A2z9V AnUFD8erlVyNhY30H9lC120G5S2PiZVhV5uQuoVwf2QMSkRira3MWakyu1U7hChj4u u1Wd8rdm6EWL/ZZQ0as0maSNe4lJxcIqhteo2mg0= From: greearb@candelatech.com To: linux-wireless@vger.kernel.org Cc: Ben Greear Subject: [PATCH] wifi: iwlwifi: Add debugging around scan failure warning. Date: Tue, 14 Nov 2023 13:23:09 -0800 Message-ID: <20231114212309.2180281-1-greearb@candelatech.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-MDID: 1699997000-6Ac7Y6sgxHi7 X-MDID-O: us5;ut7;1699997000;6Ac7Y6sgxHi7;;f7146c1849a4b08a52804beb1c1cdf45 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ben Greear Provide additional information that may help debugging why the WARN_ON is seen. Signed-off-by: Ben Greear --- drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c index 75c5c58e14a5..ec24ece7c877 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c @@ -2356,7 +2356,10 @@ iwl_mvm_scan_umac_fill_general_p_v12(struct iwl_mvm *mvm, link_id = ffs(vif->active_links) - 1; link_info = scan_vif->link[link_id]; - if (!WARN_ON(!link_info)) + if (WARN_ON(!link_info)) + IWL_ERR(mvm, "scan failure: Cannot find link info for link-id: %d active-links: 0x%x\n", + link_id, vif->active_links); + else gp->scan_start_mac_or_link_id = link_info->fw_link_id; } }