diff mbox series

[4/5] wifi: ath12k: remove redundant peer delete

Message ID 20240429081525.983-5-quic_kangyang@quicinc.com (mailing list archive)
State Changes Requested
Delegated to: Kalle Valo
Headers show
Series prepare work for monitor mode on WCN7850 | expand

Commit Message

kangyang April 29, 2024, 8:15 a.m. UTC 
From: Kang Yang <quic_kangyang@quicinc.com>

Firmware will create internal peer for monitor mode. For host no need to
do peer create and peer delete.

So remove related code.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
---
 drivers/net/wireless/ath/ath12k/mac.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Jeff Johnson April 30, 2024, 1:53 a.m. UTC | #1 
On 4/29/2024 1:15 AM, kangyang wrote:
> From: Kang Yang <quic_kangyang@quicinc.com>
> 
> Firmware will create internal peer for monitor mode. For host no need to
> do peer create and peer delete.
> 
> So remove related code.
> 
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> 
> Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Kalle Valo May 7, 2024, 10:20 a.m. UTC | #2 
kangyang <quic_kangyang@quicinc.com> wrote:

> Firmware will create internal peer for monitor mode. For host no need to
> do peer create and peer delete.
> 
> So remove related code.
> 
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> 
> Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

What about QCN9274? The commit message doesn't mention that at all. Is it safe
to assume that QCN9274 firmware acts the same?
kangyang May 7, 2024, 11:20 a.m. UTC | #3 
On 5/7/2024 6:20 PM, Kalle Valo wrote:
> kangyang <quic_kangyang@quicinc.com> wrote:
> 
>> Firmware will create internal peer for monitor mode. For host no need to
>> do peer create and peer delete.
>>
>> So remove related code.
>>
>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>>
>> Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
>> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> 
> What about QCN9274? The commit message doesn't mention that at all. Is it safe
> to assume that QCN9274 firmware acts the same?
> 


The first judgement 'ab->hw_params->vdev_start_delay' only works for 
WCN7850. It won't affect QCN9274.

Sorry, i should mention.
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index 9a2823bcf8fc..f994a78e7dc5 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -7354,11 +7354,6 @@  ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw,
 
 	WARN_ON(!arvif->is_started);
 
-	if (ab->hw_params->vdev_start_delay &&
-	    arvif->vdev_type == WMI_VDEV_TYPE_MONITOR &&
-	    ath12k_peer_find_by_addr(ab, ar->mac_addr))
-		ath12k_peer_delete(ar, arvif->vdev_id, ar->mac_addr);
-
 	if (arvif->vdev_type == WMI_VDEV_TYPE_MONITOR) {
 		ret = ath12k_mac_monitor_stop(ar);
 		if (ret) {