diff mbox series

[wpan-tools,4/7] iwpan: Remove duplicated SECTION

Message ID 20220701143434.1267864-5-miquel.raynal@bootlin.com (mailing list archive)
State New, archived
Headers show
Series iwpan: Support scanning/beaconing | expand

Commit Message

Miquel Raynal July 1, 2022, 2:34 p.m. UTC 
From: David Girault <david.girault@qorvo.com>

This section has been duplicated, drop one.

Signed-off-by: David Girault <david.girault@qorvo.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 src/iwpan.h | 6 ------
 1 file changed, 6 deletions(-)

Comments

Alexander Aring Aug. 1, 2022, 11:30 p.m. UTC | #1 
Hi,

On Fri, Jul 1, 2022 at 10:39 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> From: David Girault <david.girault@qorvo.com>
>
> This section has been duplicated, drop one.
>
> Signed-off-by: David Girault <david.girault@qorvo.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Patch 1, 2, 3 and 4 seems to be fine. So far I know we don't do
Signed-off-by on wpan-tools but it doesn't harm it is there as Stefan
would say "there is no description what to sign for".

Stefan can you take care of this I know that there is a automated ci
stuff going on which you setup (thanks again for doing it) is it just
easy as commit it to the branch "coverity_scan" and if everything is
fine it gets automatically into master (just to confirm the process
here again)?

Thanks.

- Alex
diff mbox series

Patch

diff --git a/src/iwpan.h b/src/iwpan.h
index 9d265c6..406940a 100644
--- a/src/iwpan.h
+++ b/src/iwpan.h
@@ -90,12 +90,6 @@  struct cmd {
 		.handler = (_handler),					\
 		.help = (_help),					\
 	 }
-#define SECTION(_name)							\
-	struct cmd __section ## _ ## _name				\
-	__attribute__((used)) __attribute__((section("__cmd"))) = {	\
-		.name = (#_name),					\
-		.hidden = 1,						\
-	}
 
 #define SECTION(_name)							\
 	struct cmd __section ## _ ## _name				\