Message ID | 20240424162726.204791-1-stewart.hildebrand@amd.com (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | arm/vpci: make prefetchable mem 64 bit | expand |
Hi Stewart, On 24/04/2024 18:27, Stewart Hildebrand wrote: > The vPCI prefetchable memory range is >= 4GB, so the memory space flags > should be set to 64-bit. See IEEE Std 1275-1994 [1] for a definition of NIT: would be beneficial to provide chapter (in this case 2.2.1.1) > the field. > > [1] https://www.devicetree.org/open-firmware/bindings/pci/pci2_1.pdf > > Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com> Acked-by: Michal Orzel <michal.orzel@amd.com> ~Michal > --- > xen/include/public/arch-arm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > index e167e14f8df9..289af81bd69d 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -487,7 +487,7 @@ typedef uint64_t xen_callback_t; > #define GUEST_RAM0_SIZE xen_mk_ullong(0xc0000000) > > /* 4GB @ 4GB Prefetch Memory for VPCI */ > -#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM xen_mk_ullong(0x42000000) > +#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM xen_mk_ullong(0x43000000) > #define GUEST_VPCI_PREFETCH_MEM_ADDR xen_mk_ullong(0x100000000) > #define GUEST_VPCI_PREFETCH_MEM_SIZE xen_mk_ullong(0x100000000) > > > base-commit: 410ef3343924b5a3928bbe8e392491992b322cf0
Hi Stewart, > On 24 Apr 2024, at 5:27 PM, Stewart Hildebrand <Stewart.Hildebrand@amd.com> wrote: > > The vPCI prefetchable memory range is >= 4GB, so the memory space flags > should be set to 64-bit. See IEEE Std 1275-1994 [1] for a definition of > the field. > > [1] https://www.devicetree.org/open-firmware/bindings/pci/pci2_1.pdf > > Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com> Reviewed-by: Rahul Singh <rahul.singh@arm.com> Regards, Rahul
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index e167e14f8df9..289af81bd69d 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -487,7 +487,7 @@ typedef uint64_t xen_callback_t; #define GUEST_RAM0_SIZE xen_mk_ullong(0xc0000000) /* 4GB @ 4GB Prefetch Memory for VPCI */ -#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM xen_mk_ullong(0x42000000) +#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM xen_mk_ullong(0x43000000) #define GUEST_VPCI_PREFETCH_MEM_ADDR xen_mk_ullong(0x100000000) #define GUEST_VPCI_PREFETCH_MEM_SIZE xen_mk_ullong(0x100000000)
The vPCI prefetchable memory range is >= 4GB, so the memory space flags should be set to 64-bit. See IEEE Std 1275-1994 [1] for a definition of the field. [1] https://www.devicetree.org/open-firmware/bindings/pci/pci2_1.pdf Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com> --- xen/include/public/arch-arm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 410ef3343924b5a3928bbe8e392491992b322cf0