| Message ID | 1407771634-14946-7-git-send-email-iivanov@mm-sol.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon 11 Aug 08:40 PDT 2014, Ivan T. Ivanov wrote: > diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard-pmics-pins.dtsi b/arch/arm/boot/dts/qcom-apq8074-dragonboard-pmics-pins.dtsi [...] > + > +&pm8941_gpios { > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pm8941_gpios_default>; > + > + pm8941_gpios_default: default { > + group-1 { > + pins = "gpio1", "gpio2", "gpio5", "gpio29"; > + function = PMIC_GPIO_FUNC_NORMAL; This looks really strange, I can't get myself to stop thinking that you forgot the <> around this (I know it's a string). I don't like these defines. > + input-enable; > + power-source = <PM8941_GPIO_S3>; > + qcom,pull-up-strength = <PMIC_GPIO_PULL_UP_30>; > + }; > + group-6 { /* TUSB3_HUB-RESET */ Why not name the nodes something useful? If you name it tusb3-hub-reset you can skip the comment. > + pins = "gpio6"; > + function = PMIC_GPIO_FUNC_NORMAL; > + output-high; > + drive-push-pull; > + power-source = <PM8941_GPIO_VPH>; > + qcom,pull-up-strength = <PMIC_GPIO_PULL_UP_30>; > + qcom,drive-strength = <PMIC_GPIO_STRENGTH_MED>; > + }; Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2014-08-20 at 16:06 -0700, Bjorn Andersson wrote: > On Mon 11 Aug 08:40 PDT 2014, Ivan T. Ivanov wrote: > > diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard-pmics-pins.dtsi b/arch/arm/boot/dts/qcom-apq8074-dragonboard-pmics-pins.dtsi > [...] > > + > > +&pm8941_gpios { > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pm8941_gpios_default>; > > + > > + pm8941_gpios_default: default { > > + group-1 { > > + pins = "gpio1", "gpio2", "gpio5", "gpio29"; > > + function = PMIC_GPIO_FUNC_NORMAL; > > This looks really strange, I can't get myself to stop thinking that you forgot > the <> around this (I know it's a string). I don't like these defines. Same here, any suggestions? Except function tables in driver :-) > > > + input-enable; > > + power-source = <PM8941_GPIO_S3>; > > + qcom,pull-up-strength = <PMIC_GPIO_PULL_UP_30>; > > + }; > > + group-6 { /* TUSB3_HUB-RESET */ > > Why not name the nodes something useful? > If you name it tusb3-hub-reset you can skip the comment. Sure. > Regards, > Bjorn Thanks, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard-pmics-pins.dtsi b/arch/arm/boot/dts/qcom-apq8074-dragonboard-pmics-pins.dtsi new file mode 100644 index 0000000..c69ecc2 --- /dev/null +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard-pmics-pins.dtsi @@ -0,0 +1,103 @@ + +#include <dt-bindings/pinctrl/qcom,pmic-mpp.h> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> + +&pm8941_gpios { + + pinctrl-names = "default"; + pinctrl-0 = <&pm8941_gpios_default>; + + pm8941_gpios_default: default { + group-1 { + pins = "gpio1", "gpio2", "gpio5", "gpio29"; + function = PMIC_GPIO_FUNC_NORMAL; + input-enable; + power-source = <PM8941_GPIO_S3>; + qcom,pull-up-strength = <PMIC_GPIO_PULL_UP_30>; + }; + group-6 { /* TUSB3_HUB-RESET */ + pins = "gpio6"; + function = PMIC_GPIO_FUNC_NORMAL; + output-high; + drive-push-pull; + power-source = <PM8941_GPIO_VPH>; + qcom,pull-up-strength = <PMIC_GPIO_PULL_UP_30>; + qcom,drive-strength = <PMIC_GPIO_STRENGTH_MED>; + }; + group-8 { /* HSIC_HUB-RESET */ + pins = "gpio8"; + function = PMIC_GPIO_FUNC_NORMAL; + output-low; + bias-disable; + qcom,drive-strength = <PMIC_GPIO_STRENGTH_MED>; + }; + group-9 { /* GbE_RST_N */ + pins = "gpio9"; + function = PMIC_GPIO_FUNC_NORMAL; + output-high; + drive-push-pull; + power-source = <PM8941_GPIO_VPH>; + qcom,pull-up-strength = <PMIC_GPIO_PULL_UP_30>; + qcom,drive-strength = <PMIC_GPIO_STRENGTH_MED>; + }; + group-10 { /* SATA_RST_N */ + pins = "gpio10"; + function = PMIC_GPIO_FUNC_NORMAL; + output-high; + drive-push-pull; + power-source = <PM8941_GPIO_VPH>; + qcom,pull-up-strength = <PMIC_GPIO_PULL_UP_30>; + qcom,drive-strength = <PMIC_GPIO_STRENGTH_MED>; + }; + group-15 { /* DIVCLK1_CODEC */ + pins = "gpio15"; + function = PM8941_GPIO15_18_DIV_CLK; + output-high; + drive-push-pull; + bias-disable; + power-source = <PM8941_GPIO_S3>; + qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>; + }; + group-19 { /* MIPI_DSI0_RESET_N */ + pins = "gpio19"; + function = PMIC_GPIO_FUNC_NORMAL; + output-low; + drive-push-pull; + bias-disable; + power-source = <PM8941_GPIO_S3>; + qcom,drive-strength = <PMIC_GPIO_STRENGTH_MED>; + }; + group-29 { /* SD_WP_N */ + pins = "gpio29"; + function = PMIC_GPIO_FUNC_NORMAL; + input-enable; + power-source = <PM8941_GPIO_S3>; + qcom,pull-up-strength = <PMIC_GPIO_PULL_UP_30>; + }; + group-33 { /* WLAN_PWD_L */ + pins = "gpio33"; + function = PMIC_GPIO_FUNC_NORMAL; + output-high; + drive-push-pull; + bias-disable; + power-source = <PM8941_GPIO_S3>; + qcom,drive-strength = <PMIC_GPIO_STRENGTH_MED>; + }; + group-34 { /* BT_PWD_L */ + pins = "gpio34"; + function = PMIC_GPIO_FUNC_NORMAL; + output-low; + drive-push-pull; + bias-disable; + power-source = <PM8941_GPIO_S3>; + qcom,drive-strength = <PMIC_GPIO_STRENGTH_MED>; + }; + }; +}; + +&pm8941_mpps { +}; + +&pm8841_mpps { +}; + diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts index b4dfb01..87b90e3 100644 --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts @@ -1,4 +1,5 @@ #include "qcom-msm8974.dtsi" +#include "qcom-apq8074-dragonboard-pmics-pins.dtsi" / { model = "Qualcomm APQ8074 Dragonboard";