| Message ID | 1408567315-28479-10-git-send-email-soren.brinkmann@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 08/20/2014 10:41 PM, Soren Brinkmann wrote: > Match the naming pattern of all other SMP ops and rename > zynq_platform_cpu_die --> zynq_cpu_die. > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > --- > arch/arm/mach-zynq/platsmp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-zynq/platsmp.c b/arch/arm/mach-zynq/platsmp.c > index 04e578718aa2..95933c5e70e1 100644 > --- a/arch/arm/mach-zynq/platsmp.c > +++ b/arch/arm/mach-zynq/platsmp.c > @@ -138,7 +138,7 @@ static int zynq_cpu_kill(unsigned cpu) > * > * Called with IRQs disabled > */ > -static void zynq_platform_cpu_die(unsigned int cpu) > +static void zynq_cpu_die(unsigned int cpu) > { > zynq_slcr_cpu_state_write(cpu, true); > > @@ -158,7 +158,7 @@ struct smp_operations zynq_smp_ops __initdata = { > .smp_boot_secondary = zynq_boot_secondary, > .smp_secondary_init = zynq_secondary_init, > #ifdef CONFIG_HOTPLUG_CPU > - .cpu_die = zynq_platform_cpu_die, > + .cpu_die = zynq_cpu_die, > .cpu_kill = zynq_cpu_kill, > #endif > }; Will be good if you can move fix that kernel-doc format for this function too. It is just nice to have thing. Thanks, Michal
On Thu, 2014-08-21 at 02:28PM +0200, Michal Simek wrote: > On 08/20/2014 10:41 PM, Soren Brinkmann wrote: > > Match the naming pattern of all other SMP ops and rename > > zynq_platform_cpu_die --> zynq_cpu_die. > > > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > > --- > > arch/arm/mach-zynq/platsmp.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/mach-zynq/platsmp.c b/arch/arm/mach-zynq/platsmp.c > > index 04e578718aa2..95933c5e70e1 100644 > > --- a/arch/arm/mach-zynq/platsmp.c > > +++ b/arch/arm/mach-zynq/platsmp.c > > @@ -138,7 +138,7 @@ static int zynq_cpu_kill(unsigned cpu) > > * > > * Called with IRQs disabled > > */ > > -static void zynq_platform_cpu_die(unsigned int cpu) > > +static void zynq_cpu_die(unsigned int cpu) > > { > > zynq_slcr_cpu_state_write(cpu, true); > > > > @@ -158,7 +158,7 @@ struct smp_operations zynq_smp_ops __initdata = { > > .smp_boot_secondary = zynq_boot_secondary, > > .smp_secondary_init = zynq_secondary_init, > > #ifdef CONFIG_HOTPLUG_CPU > > - .cpu_die = zynq_platform_cpu_die, > > + .cpu_die = zynq_cpu_die, > > .cpu_kill = zynq_cpu_kill, > > #endif > > }; > > Will be good if you can move fix that kernel-doc format for this function > too. It is just nice to have thing. All these SMP-ops should be documented in the header defining that struct, shouldn't they? Sören
On 08/21/2014 09:02 PM, Sören Brinkmann wrote: > On Thu, 2014-08-21 at 02:28PM +0200, Michal Simek wrote: >> On 08/20/2014 10:41 PM, Soren Brinkmann wrote: >>> Match the naming pattern of all other SMP ops and rename >>> zynq_platform_cpu_die --> zynq_cpu_die. >>> >>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> >>> --- >>> arch/arm/mach-zynq/platsmp.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm/mach-zynq/platsmp.c b/arch/arm/mach-zynq/platsmp.c >>> index 04e578718aa2..95933c5e70e1 100644 >>> --- a/arch/arm/mach-zynq/platsmp.c >>> +++ b/arch/arm/mach-zynq/platsmp.c >>> @@ -138,7 +138,7 @@ static int zynq_cpu_kill(unsigned cpu) >>> * >>> * Called with IRQs disabled >>> */ >>> -static void zynq_platform_cpu_die(unsigned int cpu) >>> +static void zynq_cpu_die(unsigned int cpu) >>> { Sorry for incorrect place - I mean to use kernel-doc here not below. :-) >>> zynq_slcr_cpu_state_write(cpu, true); >>> >>> @@ -158,7 +158,7 @@ struct smp_operations zynq_smp_ops __initdata = { >>> .smp_boot_secondary = zynq_boot_secondary, >>> .smp_secondary_init = zynq_secondary_init, >>> #ifdef CONFIG_HOTPLUG_CPU >>> - .cpu_die = zynq_platform_cpu_die, >>> + .cpu_die = zynq_cpu_die, >>> .cpu_kill = zynq_cpu_kill, >>> #endif >>> }; >> >> Will be good if you can move fix that kernel-doc format for this function >> too. It is just nice to have thing. > > All these SMP-ops should be documented in the header defining that > struct, shouldn't they? This struct is not necessary. I have added comment to wrong place. Thanks, Michal
diff --git a/arch/arm/mach-zynq/platsmp.c b/arch/arm/mach-zynq/platsmp.c index 04e578718aa2..95933c5e70e1 100644 --- a/arch/arm/mach-zynq/platsmp.c +++ b/arch/arm/mach-zynq/platsmp.c @@ -138,7 +138,7 @@ static int zynq_cpu_kill(unsigned cpu) * * Called with IRQs disabled */ -static void zynq_platform_cpu_die(unsigned int cpu) +static void zynq_cpu_die(unsigned int cpu) { zynq_slcr_cpu_state_write(cpu, true); @@ -158,7 +158,7 @@ struct smp_operations zynq_smp_ops __initdata = { .smp_boot_secondary = zynq_boot_secondary, .smp_secondary_init = zynq_secondary_init, #ifdef CONFIG_HOTPLUG_CPU - .cpu_die = zynq_platform_cpu_die, + .cpu_die = zynq_cpu_die, .cpu_kill = zynq_cpu_kill, #endif };
Match the naming pattern of all other SMP ops and rename zynq_platform_cpu_die --> zynq_cpu_die. Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> --- arch/arm/mach-zynq/platsmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)