| Message ID | 007701cfbdd1$a70486e0$f50d94a0$%han@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Aug 22, 2014 at 8:23 AM, Jingoo Han <jg1.han@samsung.com> wrote: > Remove unnecessary #ifdef CONFIG_OF, because this is already > handled by the of_match_ptr macro. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/video/backlight/platform_lcd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/video/backlight/platform_lcd.c b/drivers/video/backlight/platform_lcd.c > index c3d2e209fc8f..2bca5ca760ee 100644 > --- a/drivers/video/backlight/platform_lcd.c > +++ b/drivers/video/backlight/platform_lcd.c > @@ -137,13 +137,11 @@ static int platform_lcd_resume(struct device *dev) > static SIMPLE_DEV_PM_OPS(platform_lcd_pm_ops, platform_lcd_suspend, > platform_lcd_resume); > > -#ifdef CONFIG_OF > static const struct of_device_id platform_lcd_of_match[] = { > { .compatible = "platform-lcd" }, > {}, > }; > MODULE_DEVICE_TABLE(of, platform_lcd_of_match); > -#endif > > static struct platform_driver platform_lcd_driver = { > .driver = { Doesn't this introduce a compiler warning ("defined but not used") if CONFIG_OF is not set? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday, August 22, 2014 4:13 PM, Jingoo Han wrote: > On Fri, Aug 22, 2014 at 8:23 AM, Jingoo Han <jg1.han@samsung.com> wrote: > > Remove unnecessary #ifdef CONFIG_OF, because this is already > > handled by the of_match_ptr macro. > > > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > > --- > > drivers/video/backlight/platform_lcd.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/video/backlight/platform_lcd.c b/drivers/video/backlight/platform_lcd.c > > index c3d2e209fc8f..2bca5ca760ee 100644 > > --- a/drivers/video/backlight/platform_lcd.c > > +++ b/drivers/video/backlight/platform_lcd.c > > @@ -137,13 +137,11 @@ static int platform_lcd_resume(struct device *dev) > > static SIMPLE_DEV_PM_OPS(platform_lcd_pm_ops, platform_lcd_suspend, > > platform_lcd_resume); > > > > -#ifdef CONFIG_OF > > static const struct of_device_id platform_lcd_of_match[] = { > > { .compatible = "platform-lcd" }, > > {}, > > }; > > MODULE_DEVICE_TABLE(of, platform_lcd_of_match); > > -#endif > > > > static struct platform_driver platform_lcd_driver = { > > .driver = { > > Doesn't this introduce a compiler warning ("defined but not used") if > CONFIG_OF is not set? Hi Geert Uytterhoeven, Thank you for your feedback. I already tested this patch with both cases such as CONFIG_OF=y and CONFIG_OF=n. When CONFIG_OF is not set, it does NOT make any compile warnings such as "defined but not used". Thank you. Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/backlight/platform_lcd.c b/drivers/video/backlight/platform_lcd.c index c3d2e209fc8f..2bca5ca760ee 100644 --- a/drivers/video/backlight/platform_lcd.c +++ b/drivers/video/backlight/platform_lcd.c @@ -137,13 +137,11 @@ static int platform_lcd_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(platform_lcd_pm_ops, platform_lcd_suspend, platform_lcd_resume); -#ifdef CONFIG_OF static const struct of_device_id platform_lcd_of_match[] = { { .compatible = "platform-lcd" }, {}, }; MODULE_DEVICE_TABLE(of, platform_lcd_of_match); -#endif static struct platform_driver platform_lcd_driver = { .driver = {
Remove unnecessary #ifdef CONFIG_OF, because this is already handled by the of_match_ptr macro. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/video/backlight/platform_lcd.c | 2 -- 1 file changed, 2 deletions(-)