| Message ID | 1408725508-24066-1-git-send-email-dianders@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Freitag, 22. August 2014, 09:38:28 schrieb Doug Anderson: > The clocks for i2c1 and i2c2 are flipped. The clock tree matched the > Technical Reference Manual (TRM) but the TRM was wrong. Swap them in > the clock tree. This was determined experimentally (by Addy) and > confirmed by the Rockchip IC team. > > Seires-cc: Eddie Cai <eddie.cai@rock-chips.com> I guess this is a typo... > Signed-off-by: Doug Anderson <dianders@chromium.org> > Reported-by: Addy Ke <addy.ke@rock-chips.com> The error-case we discussed yesterday was quite clear, so Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/clk/rockchip/clk-rk3288.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/rockchip/clk-rk3288.c > b/drivers/clk/rockchip/clk-rk3288.c index 0d8c6c5..b22a2d2 100644 > --- a/drivers/clk/rockchip/clk-rk3288.c > +++ b/drivers/clk/rockchip/clk-rk3288.c > @@ -545,7 +545,7 @@ static struct rockchip_clk_branch rk3288_clk_branches[] > __initdata = { GATE(PCLK_PWM, "pclk_pwm", "pclk_cpu", 0, > RK3288_CLKGATE_CON(10), 0, GFLAGS), GATE(PCLK_TIMER, "pclk_timer", > "pclk_cpu", 0, RK3288_CLKGATE_CON(10), 1, GFLAGS), GATE(PCLK_I2C0, > "pclk_i2c0", "pclk_cpu", 0, RK3288_CLKGATE_CON(10), 2, GFLAGS), > - GATE(PCLK_I2C1, "pclk_i2c1", "pclk_cpu", 0, RK3288_CLKGATE_CON(10), 3, > GFLAGS), + GATE(PCLK_I2C2, "pclk_i2c2", "pclk_cpu", 0, > RK3288_CLKGATE_CON(10), 3, GFLAGS), GATE(0, "pclk_ddrupctl0", "pclk_cpu", > 0, RK3288_CLKGATE_CON(10), 14, GFLAGS), GATE(0, "pclk_publ0", "pclk_cpu", > 0, RK3288_CLKGATE_CON(10), 15, GFLAGS), GATE(0, "pclk_ddrupctl1", > "pclk_cpu", 0, RK3288_CLKGATE_CON(11), 0, GFLAGS), @@ -603,7 +603,7 @@ > static struct rockchip_clk_branch rk3288_clk_branches[] __initdata = { > GATE(PCLK_I2C4, "pclk_i2c4", "pclk_peri", 0, RK3288_CLKGATE_CON(6), 15, > GFLAGS), GATE(PCLK_UART3, "pclk_uart3", "pclk_peri", 0, > RK3288_CLKGATE_CON(6), 11, GFLAGS), GATE(PCLK_UART4, "pclk_uart4", > "pclk_peri", 0, RK3288_CLKGATE_CON(6), 12, GFLAGS), - GATE(PCLK_I2C2, > "pclk_i2c2", "pclk_peri", 0, RK3288_CLKGATE_CON(6), 13, GFLAGS), > + GATE(PCLK_I2C1, "pclk_i2c1", "pclk_peri", 0, RK3288_CLKGATE_CON(6), 13, > GFLAGS), GATE(PCLK_I2C3, "pclk_i2c3", "pclk_peri", 0, > RK3288_CLKGATE_CON(6), 14, GFLAGS), GATE(PCLK_SARADC, "pclk_saradc", > "pclk_peri", 0, RK3288_CLKGATE_CON(7), 1, GFLAGS), GATE(PCLK_TSADC, > "pclk_tsadc", "pclk_peri", 0, RK3288_CLKGATE_CON(7), 2, GFLAGS),
Heiko, On Fri, Aug 22, 2014 at 9:46 AM, Heiko Stübner <heiko@sntech.de> wrote: > Am Freitag, 22. August 2014, 09:38:28 schrieb Doug Anderson: >> The clocks for i2c1 and i2c2 are flipped. The clock tree matched the >> Technical Reference Manual (TRM) but the TRM was wrong. Swap them in >> the clock tree. This was determined experimentally (by Addy) and >> confirmed by the Rockchip IC team. >> >> Seires-cc: Eddie Cai <eddie.cai@rock-chips.com> > > I guess this is a typo... Doh, let me repost just to make it clear. Sorry about that! :(
Hi, On Fri, Aug 22, 2014 at 9:46 AM, Heiko Stübner <heiko@sntech.de> wrote: > Am Freitag, 22. August 2014, 09:38:28 schrieb Doug Anderson: >> The clocks for i2c1 and i2c2 are flipped. The clock tree matched the >> Technical Reference Manual (TRM) but the TRM was wrong. Swap them in >> the clock tree. This was determined experimentally (by Addy) and >> confirmed by the Rockchip IC team. >> >> Seires-cc: Eddie Cai <eddie.cai@rock-chips.com> > > I guess this is a typo... > > >> Signed-off-by: Doug Anderson <dianders@chromium.org> >> Reported-by: Addy Ke <addy.ke@rock-chips.com> > > The error-case we discussed yesterday was quite clear, so > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> Just in case anyone reading was wondering: I've now received a new version of the TRM (technical reference manual) the confirms the correctness of this patch. Mike: maybe you could apply it to 3.17 fixups? -Doug
diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c index 0d8c6c5..b22a2d2 100644 --- a/drivers/clk/rockchip/clk-rk3288.c +++ b/drivers/clk/rockchip/clk-rk3288.c @@ -545,7 +545,7 @@ static struct rockchip_clk_branch rk3288_clk_branches[] __initdata = { GATE(PCLK_PWM, "pclk_pwm", "pclk_cpu", 0, RK3288_CLKGATE_CON(10), 0, GFLAGS), GATE(PCLK_TIMER, "pclk_timer", "pclk_cpu", 0, RK3288_CLKGATE_CON(10), 1, GFLAGS), GATE(PCLK_I2C0, "pclk_i2c0", "pclk_cpu", 0, RK3288_CLKGATE_CON(10), 2, GFLAGS), - GATE(PCLK_I2C1, "pclk_i2c1", "pclk_cpu", 0, RK3288_CLKGATE_CON(10), 3, GFLAGS), + GATE(PCLK_I2C2, "pclk_i2c2", "pclk_cpu", 0, RK3288_CLKGATE_CON(10), 3, GFLAGS), GATE(0, "pclk_ddrupctl0", "pclk_cpu", 0, RK3288_CLKGATE_CON(10), 14, GFLAGS), GATE(0, "pclk_publ0", "pclk_cpu", 0, RK3288_CLKGATE_CON(10), 15, GFLAGS), GATE(0, "pclk_ddrupctl1", "pclk_cpu", 0, RK3288_CLKGATE_CON(11), 0, GFLAGS), @@ -603,7 +603,7 @@ static struct rockchip_clk_branch rk3288_clk_branches[] __initdata = { GATE(PCLK_I2C4, "pclk_i2c4", "pclk_peri", 0, RK3288_CLKGATE_CON(6), 15, GFLAGS), GATE(PCLK_UART3, "pclk_uart3", "pclk_peri", 0, RK3288_CLKGATE_CON(6), 11, GFLAGS), GATE(PCLK_UART4, "pclk_uart4", "pclk_peri", 0, RK3288_CLKGATE_CON(6), 12, GFLAGS), - GATE(PCLK_I2C2, "pclk_i2c2", "pclk_peri", 0, RK3288_CLKGATE_CON(6), 13, GFLAGS), + GATE(PCLK_I2C1, "pclk_i2c1", "pclk_peri", 0, RK3288_CLKGATE_CON(6), 13, GFLAGS), GATE(PCLK_I2C3, "pclk_i2c3", "pclk_peri", 0, RK3288_CLKGATE_CON(6), 14, GFLAGS), GATE(PCLK_SARADC, "pclk_saradc", "pclk_peri", 0, RK3288_CLKGATE_CON(7), 1, GFLAGS), GATE(PCLK_TSADC, "pclk_tsadc", "pclk_peri", 0, RK3288_CLKGATE_CON(7), 2, GFLAGS),
The clocks for i2c1 and i2c2 are flipped. The clock tree matched the Technical Reference Manual (TRM) but the TRM was wrong. Swap them in the clock tree. This was determined experimentally (by Addy) and confirmed by the Rockchip IC team. Seires-cc: Eddie Cai <eddie.cai@rock-chips.com> Signed-off-by: Doug Anderson <dianders@chromium.org> Reported-by: Addy Ke <addy.ke@rock-chips.com> --- drivers/clk/rockchip/clk-rk3288.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)