diff mbox

ARM: zynq: DT: Add LEDs to zc702 DT

Message ID 1409242973-2735-1-git-send-email-soren.brinkmann@xilinx.com (mailing list archive)
State New, archived
Headers show

Commit Message

Soren Brinkmann Aug. 28, 2014, 4:22 p.m. UTC 
From: Ezra Savard <ezra.savard@xilinx.com>

Adds LEDs to the zc702 devicetree for use with the leds-gpio driver.

Signed-off-by: Ezra Savard <ezra.savard@xilinx.com>
Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
 arch/arm/boot/dts/zynq-zc702.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Soren Brinkmann Aug. 28, 2014, 5:15 p.m. UTC | #1 
On Thu, 2014-08-28 at 09:22AM -0700, Soren Brinkmann wrote:
> From: Ezra Savard <ezra.savard@xilinx.com>
> 
> Adds LEDs to the zc702 devicetree for use with the leds-gpio driver.
> 
> Signed-off-by: Ezra Savard <ezra.savard@xilinx.com>
> Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
>  arch/arm/boot/dts/zynq-zc702.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
> index 835c3089c61c..4e9fe26b3e85 100644
> --- a/arch/arm/boot/dts/zynq-zc702.dts
> +++ b/arch/arm/boot/dts/zynq-zc702.dts
> @@ -27,6 +27,16 @@
>  		bootargs = "console=ttyPS0,115200 earlyprintk";
>  	};
>  
> +	gpio-leds {
The node name should rather be just 'leds'. That slipped through, sorry.
Do you want a v2 for that?

	Soren
Michal Simek Aug. 29, 2014, 4:57 a.m. UTC | #2 
On 08/28/2014 07:15 PM, Sören Brinkmann wrote:
> On Thu, 2014-08-28 at 09:22AM -0700, Soren Brinkmann wrote:
>> From: Ezra Savard <ezra.savard@xilinx.com>
>>
>> Adds LEDs to the zc702 devicetree for use with the leds-gpio driver.
>>
>> Signed-off-by: Ezra Savard <ezra.savard@xilinx.com>
>> Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>> ---
>>  arch/arm/boot/dts/zynq-zc702.dts | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
>> index 835c3089c61c..4e9fe26b3e85 100644
>> --- a/arch/arm/boot/dts/zynq-zc702.dts
>> +++ b/arch/arm/boot/dts/zynq-zc702.dts
>> @@ -27,6 +27,16 @@
>>  		bootargs = "console=ttyPS0,115200 earlyprintk";
>>  	};
>>  
>> +	gpio-leds {
> The node name should rather be just 'leds'. That slipped through, sorry.
> Do you want a v2 for that?

yes, please send v2.

Thanks,
Michal
diff mbox

Patch

diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
index 835c3089c61c..4e9fe26b3e85 100644
--- a/arch/arm/boot/dts/zynq-zc702.dts
+++ b/arch/arm/boot/dts/zynq-zc702.dts
@@ -27,6 +27,16 @@ 
 		bootargs = "console=ttyPS0,115200 earlyprintk";
 	};
 
+	gpio-leds {
+		compatible = "gpio-leds";
+
+		led-ds23 {
+			label = "ds23";
+			gpios = <&gpio0 10 0>;
+			linux,default-trigger = "heartbeat";
+		};
+	};
+
 };
 
 &can0 {