| Message ID | 1409288168-6537-1-git-send-email-jacob.jun.pan@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Thursday, August 28, 2014 09:56:08 PM Jacob Pan wrote: > Many CPUs do not support complete set of RAPL domains, as a > result this detection failed message is very misleading and > annoying. So lower the warning message to info and reword. > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> What about printing a (info-level) message if the RAPL domain *is* supported? That surely is more interesting? > --- > drivers/powercap/intel_rapl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c > index b1cda6f..0b282e7 100644 > --- a/drivers/powercap/intel_rapl.c > +++ b/drivers/powercap/intel_rapl.c > @@ -1169,7 +1169,7 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu) > if (!rapl_check_domain(cpu, i)) > rp->domain_map |= 1 << i; > else > - pr_warn("RAPL domain %s detection failed\n", > + pr_info("RAPL domain %s not supported\n", > rapl_domain_names[i]); > } > rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX); >
On Tue, 02 Sep 2014 01:48:40 +0200 "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote: > On Thursday, August 28, 2014 09:56:08 PM Jacob Pan wrote: > > Many CPUs do not support complete set of RAPL domains, as a > > result this detection failed message is very misleading and > > annoying. So loweab Pan <jacob.jun.pan@linux.intel.com> > > What about printing a (info-level) message if the RAPL domain *is* > supported? That surely is more interesting? > yes, that is better. just sent out an updated patch with a different Subject: [PATCH] powercap/rapl: change domain detection message Thanks, Jacob > > --- > > drivers/powercap/intel_rapl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/powercap/intel_rapl.c > > b/drivers/powercap/intel_rapl.c index b1cda6f..0b282e7 100644 > > --- a/drivers/powercap/intel_rapl.c > > +++ b/drivers/powercap/intel_rapl.c > > @@ -1169,7 +1169,7 @@ static int rapl_detect_domains(struct > > rapl_package *rp, int cpu) if (!rapl_check_domain(cpu, i)) > > rp->domain_map |= 1 << i; > > else > > - pr_warn("RAPL domain %s detection > > failed\n", > > + pr_info("RAPL domain %s not supported\n", > > rapl_domain_names[i]); > > } > > rp->nr_domains = bitmap_weight(&rp->domain_map, > > RAPL_DOMAIN_MAX); > > > [Jacob Pan] -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c index b1cda6f..0b282e7 100644 --- a/drivers/powercap/intel_rapl.c +++ b/drivers/powercap/intel_rapl.c @@ -1169,7 +1169,7 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu) if (!rapl_check_domain(cpu, i)) rp->domain_map |= 1 << i; else - pr_warn("RAPL domain %s detection failed\n", + pr_info("RAPL domain %s not supported\n", rapl_domain_names[i]); } rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX);
Many CPUs do not support complete set of RAPL domains, as a result this detection failed message is very misleading and annoying. So lower the warning message to info and reword. Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> --- drivers/powercap/intel_rapl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)