| Message ID | 1408533593-32346-6-git-send-email-javier.martinez@collabora.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Javier, On Wed, Aug 20, 2014 at 4:19 AM, Javier Martinez Canillas <javier.martinez@collabora.co.uk> wrote: > The Exynos5420 based Peach Pit and the Exynos5800 based Peach Pi > machines have an i2c ISL29018 light sensor. This patch adds the > device nodes needed to support this device. > > These DTS snippets were taken from the downstream Chrome OS 3.8 > kernel Device Tree for Peach Pit and Pi boards. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > --- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 6 ++++++ > arch/arm/boot/dts/exynos5800-peach-pi.dts | 6 ++++++ > 2 files changed, 12 insertions(+) I would note that the downstream dts file has this i2c bus at 400kHz. ...but that's not a problem with your patch. Perhaps you could submit that as a separate patch? Reviewed-by: Doug Anderson <dianders@chromium.org>
Hello Doug, On 09/10/2014 06:52 AM, Doug Anderson wrote: > > I would note that the downstream dts file has this i2c bus at 400kHz. > ...but that's not a problem with your patch. Perhaps you could submit > that as a separate patch? > Indeed, I've to re-spin anyways so I'll include that on the next version as a separate patch. > Reviewed-by: Doug Anderson <dianders@chromium.org> > Best regards, Javier
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index 94225e6..455bfb8 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -499,6 +499,12 @@ pinctrl-names = "default"; pinctrl-0 = <&max98090_irq>; }; + + light-sensor@44 { + compatible = "isil,isl29018"; + reg = <0x44>; + vcc-supply = <&tps65090_fet5>; + }; }; &hsi2c_9 { diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index 8f9d66e..03bbe79 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -497,6 +497,12 @@ pinctrl-names = "default"; pinctrl-0 = <&max98091_irq>; }; + + light-sensor@44 { + compatible = "isil,isl29018"; + reg = <0x44>; + vcc-supply = <&tps65090_fet5>; + }; }; &hsi2c_9 {
The Exynos5420 based Peach Pit and the Exynos5800 based Peach Pi machines have an i2c ISL29018 light sensor. This patch adds the device nodes needed to support this device. These DTS snippets were taken from the downstream Chrome OS 3.8 kernel Device Tree for Peach Pit and Pi boards. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 6 ++++++ arch/arm/boot/dts/exynos5800-peach-pi.dts | 6 ++++++ 2 files changed, 12 insertions(+)