| Message ID | 1410374404-25832-1-git-send-email-pingc@wacom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Wed, Sep 10, 2014 at 2:40 PM, Ping Cheng <pinglinux@gmail.com> wrote: > RW : ug=rw,o=r > WO : ug=w > > Signed-off-by: Paul A. Tessier <phernost@gmail.com> > Signed-Off-by: Ping Cheng <pingc@wacom.com> > Tested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > drivers/hid/wacom_sys.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c > index f0db7ec..2ce102b 100644 > --- a/drivers/hid/wacom_sys.c > +++ b/drivers/hid/wacom_sys.c > @@ -23,6 +23,9 @@ > #define WAC_CMD_ICON_BT_XFER 0x26 > #define WAC_CMD_RETRIES 10 > > +#define DEV_ATTR_RW_PERM (S_IRUGO | S_IWUSR | S_IWGRP) > +#define DEV_ATTR_WO_PERM (S_IWUSR | S_IWGRP) > + I guess you missed the correct split with 2/4 :) Please also add in this patch where these defines are used. Cheers, Benjamin > static int wacom_get_report(struct hid_device *hdev, u8 type, u8 id, > void *buf, size_t size, unsigned int retries) > { > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index f0db7ec..2ce102b 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -23,6 +23,9 @@ #define WAC_CMD_ICON_BT_XFER 0x26 #define WAC_CMD_RETRIES 10 +#define DEV_ATTR_RW_PERM (S_IRUGO | S_IWUSR | S_IWGRP) +#define DEV_ATTR_WO_PERM (S_IWUSR | S_IWGRP) + static int wacom_get_report(struct hid_device *hdev, u8 type, u8 id, void *buf, size_t size, unsigned int retries) {