diff mbox

[media] davinci: remove an unneeded check

Message ID 20140922080008.GB12362@mwanda (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter Sept. 22, 2014, 8 a.m. UTC 
We don't need to check "ret", we know it's zero.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Lad, Prabhakar Sept. 23, 2014, 6:36 a.m. UTC | #1 
Hi Dan,

Thanks for the patch!

On Mon, Sep 22, 2014 at 9:00 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We don't need to check "ret", we know it's zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Regards,
--Prabhakar Lad

>
> diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c
> index c557eb5..3eb6e4b 100644
> --- a/drivers/media/platform/davinci/vpfe_capture.c
> +++ b/drivers/media/platform/davinci/vpfe_capture.c
> @@ -442,11 +442,10 @@ static int vpfe_config_image_format(struct vpfe_device *vpfe_dev,
>                 return ret;
>
>         /* Update the values of sizeimage and bytesperline */
> -       if (!ret) {
> -               pix->bytesperline = ccdc_dev->hw_ops.get_line_length();
> -               pix->sizeimage = pix->bytesperline * pix->height;
> -       }
> -       return ret;
> +       pix->bytesperline = ccdc_dev->hw_ops.get_line_length();
> +       pix->sizeimage = pix->bytesperline * pix->height;
> +
> +       return 0;
>  }
>
>  static int vpfe_initialize_device(struct vpfe_device *vpfe_dev)
diff mbox

Patch

diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c
index c557eb5..3eb6e4b 100644
--- a/drivers/media/platform/davinci/vpfe_capture.c
+++ b/drivers/media/platform/davinci/vpfe_capture.c
@@ -442,11 +442,10 @@  static int vpfe_config_image_format(struct vpfe_device *vpfe_dev,
 		return ret;
 
 	/* Update the values of sizeimage and bytesperline */
-	if (!ret) {
-		pix->bytesperline = ccdc_dev->hw_ops.get_line_length();
-		pix->sizeimage = pix->bytesperline * pix->height;
-	}
-	return ret;
+	pix->bytesperline = ccdc_dev->hw_ops.get_line_length();
+	pix->sizeimage = pix->bytesperline * pix->height;
+
+	return 0;
 }
 
 static int vpfe_initialize_device(struct vpfe_device *vpfe_dev)