| Message ID | d508a6ad39e07d5489c4b5110784902ab0241c44.1411378369.git.bhuvanchandra.dv@toradex.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Sep 22, 2014 at 03:38:11PM +0530, Bhuvanchandra DV wrote: > The Colibri standard defines four pins as PWM outputs, two of them (PWM > A and C) are routed to FTM instance 0 and the other two (PWM B and D) > are routed to FTM instance 1. Hence enable both FTM instances for the > Colibri module and mux the four pins accordingly. > > Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> You should add Stefan's ACK tag. > --- > arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 ++++++++ > arch/arm/boot/dts/vf610-colibri.dtsi | 24 ++++++++++++++++++++++++ > 2 files changed, 32 insertions(+) > > diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > index 7fb3066..00f63d9 100644 > --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > @@ -33,6 +33,14 @@ > status = "okay"; > }; > > +&pwm0 { > + status = "okay"; > +}; > + > +&pwm1 { > + status = "okay"; > +}; > + I was trying to apply the patches, but found pwm1 is not available in vf610.dtsi at all. What tree is your patch generated against? Or did I miss any prerequisite patches? Shawn > &uart0 { > status = "okay"; > }; > diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi > index 0cd8343..1f73c1c 100644 > --- a/arch/arm/boot/dts/vf610-colibri.dtsi > +++ b/arch/arm/boot/dts/vf610-colibri.dtsi > @@ -44,6 +44,16 @@ > arm,tag-latency = <3 2 3>; > }; > > +&pwm0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pwm0>; > +}; > + > +&pwm1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pwm1>; > +}; > + > &uart0 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart0>; > @@ -97,6 +107,20 @@ > >; > }; > > + pinctrl_pwm0: pwm0grp { > + fsl,pins = < > + VF610_PAD_PTB0__FTM0_CH0 0x1182 > + VF610_PAD_PTB1__FTM0_CH1 0x1182 > + >; > + }; > + > + pinctrl_pwm1: pwm1grp { > + fsl,pins = < > + VF610_PAD_PTB8__FTM1_CH0 0x1182 > + VF610_PAD_PTB9__FTM1_CH1 0x1182 > + >; > + }; > + > pinctrl_uart0: uart0grp { > fsl,pins = < > VF610_PAD_PTB10__UART0_TX 0x21a2 > -- > 1.7.9.5 >
On Sun, Sep 28, 2014 at 09:38:43AM -0700, BhuvanChandra.DV wrote: > One prerequisite patch(PATCH 1/3) was missed. Available over here: > https://lkml.org/lkml/2014/9/17/86 For any prerequisite patches that haven't been applied, you should either include it in your series or mention the dependency in the cover letter. For this thime, I just picked the prerequisite and applied these two with Stefan's ACK. Shawn
On 9/25/2014 7:22 PM, Shawn Guo wrote: > On Mon, Sep 22, 2014 at 03:38:11PM +0530, Bhuvanchandra DV wrote: >> The Colibri standard defines four pins as PWM outputs, two of them (PWM >> A and C) are routed to FTM instance 0 and the other two (PWM B and D) >> are routed to FTM instance 1. Hence enable both FTM instances for the >> Colibri module and mux the four pins accordingly. >> >> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> > You should add Stefan's ACK tag. Ok >> --- >> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 ++++++++ >> arch/arm/boot/dts/vf610-colibri.dtsi | 24 ++++++++++++++++++++++++ >> 2 files changed, 32 insertions(+) >> >> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> index 7fb3066..00f63d9 100644 >> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> @@ -33,6 +33,14 @@ >> status = "okay"; >> }; >> >> +&pwm0 { >> + status = "okay"; >> +}; >> + >> +&pwm1 { >> + status = "okay"; >> +}; >> + > I was trying to apply the patches, but found pwm1 is not available in > vf610.dtsi at all. What tree is your patch generated against? Or did I > miss any prerequisite patches? > > Shawn One prerequisite patch(PATCH 1/3) was missed. Available over here: https://lkml.org/lkml/2014/9/17/86 >> &uart0 { >> status = "okay"; >> }; >> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi >> index 0cd8343..1f73c1c 100644 >> --- a/arch/arm/boot/dts/vf610-colibri.dtsi >> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi >> @@ -44,6 +44,16 @@ >> arm,tag-latency = <3 2 3>; >> }; >> >> +&pwm0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_pwm0>; >> +}; >> + >> +&pwm1 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_pwm1>; >> +}; >> + >> &uart0 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_uart0>; >> @@ -97,6 +107,20 @@ >> >; >> }; >> >> + pinctrl_pwm0: pwm0grp { >> + fsl,pins = < >> + VF610_PAD_PTB0__FTM0_CH0 0x1182 >> + VF610_PAD_PTB1__FTM0_CH1 0x1182 >> + >; >> + }; >> + >> + pinctrl_pwm1: pwm1grp { >> + fsl,pins = < >> + VF610_PAD_PTB8__FTM1_CH0 0x1182 >> + VF610_PAD_PTB9__FTM1_CH1 0x1182 >> + >; >> + }; >> + >> pinctrl_uart0: uart0grp { >> fsl,pins = < >> VF610_PAD_PTB10__UART0_TX 0x21a2 >> -- >> 1.7.9.5 >>
On Sunday 28 September 2014 06:54 AM, Shawn Guo wrote: > On Sun, Sep 28, 2014 at 09:38:43AM -0700, BhuvanChandra.DV wrote: >> One prerequisite patch(PATCH 1/3) was missed. Available over here: >> https://lkml.org/lkml/2014/9/17/86 > For any prerequisite patches that haven't been applied, you should > either include it in your series or mention the dependency in the cover > letter. OK > For this thime, I just picked the prerequisite and applied these two > with Stefan's ACK. Thanks Shawn > > Shawn
diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts index 7fb3066..00f63d9 100644 --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts @@ -33,6 +33,14 @@ status = "okay"; }; +&pwm0 { + status = "okay"; +}; + +&pwm1 { + status = "okay"; +}; + &uart0 { status = "okay"; }; diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi index 0cd8343..1f73c1c 100644 --- a/arch/arm/boot/dts/vf610-colibri.dtsi +++ b/arch/arm/boot/dts/vf610-colibri.dtsi @@ -44,6 +44,16 @@ arm,tag-latency = <3 2 3>; }; +&pwm0 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm0>; +}; + +&pwm1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm1>; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart0>; @@ -97,6 +107,20 @@ >; }; + pinctrl_pwm0: pwm0grp { + fsl,pins = < + VF610_PAD_PTB0__FTM0_CH0 0x1182 + VF610_PAD_PTB1__FTM0_CH1 0x1182 + >; + }; + + pinctrl_pwm1: pwm1grp { + fsl,pins = < + VF610_PAD_PTB8__FTM1_CH0 0x1182 + VF610_PAD_PTB9__FTM1_CH1 0x1182 + >; + }; + pinctrl_uart0: uart0grp { fsl,pins = < VF610_PAD_PTB10__UART0_TX 0x21a2
The Colibri standard defines four pins as PWM outputs, two of them (PWM A and C) are routed to FTM instance 0 and the other two (PWM B and D) are routed to FTM instance 1. Hence enable both FTM instances for the Colibri module and mux the four pins accordingly. Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> --- arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 ++++++++ arch/arm/boot/dts/vf610-colibri.dtsi | 24 ++++++++++++++++++++++++ 2 files changed, 32 insertions(+)