diff mbox

nouveau: fix 32bit builds

Message ID 1411928510-1127-1-git-send-email-emil.l.velikov@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Emil Velikov Sept. 28, 2014, 6:21 p.m. UTC
On 32bit platforms we have to provide _FILE_OFFSET_BITS via config.h
otherwise the static assert in drm_munmap will trigger.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84428
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
---
 nouveau/private.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Rob Clark Sept. 28, 2014, 6:33 p.m. UTC | #1
no, config.h needs to be in the .c files.. plus a lot more than just
nouveau..  I've pushed a patch which fixes it for everyone but
(potentially) intel, since I can't build libdrm_intel on 32b arm ;-)

Someone please test 32b intel build before I push another release

BR,
-R

On Sun, Sep 28, 2014 at 2:21 PM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> On 32bit platforms we have to provide _FILE_OFFSET_BITS via config.h
> otherwise the static assert in drm_munmap will trigger.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84428
> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
> ---
>  nouveau/private.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/nouveau/private.h b/nouveau/private.h
> index bf9db04..8176267 100644
> --- a/nouveau/private.h
> +++ b/nouveau/private.h
> @@ -1,6 +1,10 @@
>  #ifndef __NOUVEAU_LIBDRM_PRIVATE_H__
>  #define __NOUVEAU_LIBDRM_PRIVATE_H__
>
> +#ifdef HAVE_CONFIG_H
> +#include <config.h>
> +#endif
> +
>  #include <libdrm.h>
>  #include <xf86drm.h>
>  #include <xf86atomic.h>
> --
> 2.1.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/nouveau/private.h b/nouveau/private.h
index bf9db04..8176267 100644
--- a/nouveau/private.h
+++ b/nouveau/private.h
@@ -1,6 +1,10 @@ 
 #ifndef __NOUVEAU_LIBDRM_PRIVATE_H__
 #define __NOUVEAU_LIBDRM_PRIVATE_H__
 
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
 #include <libdrm.h>
 #include <xf86drm.h>
 #include <xf86atomic.h>