| Message ID | 1411749127-12746-1-git-send-email-mike.rapoport@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Mike, On 09/26/14 19:32, Mike Rapoport wrote: > CM-QS600 is a APQ8064 based computer on module. > The details are available at > http://compulab.co.il/products/computer-on-modules/cm-qs600/ > > Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com> Thanks for working on this! Some minor notes... Can we have the subject aligned with other submissions, e.g. ARM: dts: qcom: ... ? > --- > v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested > v3 changes: add board details and keep dts Makefile sorted alphabetically [...] > new file mode 100644 > index 0000000..db7cf03 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts > @@ -0,0 +1,59 @@ [...] > + eeprom: eeprom@52 { > + compatible = "atmel,24c128"; I believe the above should be 24c02. And the address is 0x50. > + reg = <0x52>; > + pagesize = <32>; pagesize is 16. [...] Apart from the eeprom stuff above: Acked-by: Igor Grinberg <grinberg@compulab.co.il>
On 09/29/14 12:35, Igor Grinberg wrote: > Hi Mike, > > On 09/26/14 19:32, Mike Rapoport wrote: >> CM-QS600 is a APQ8064 based computer on module. >> The details are available at >> http://compulab.co.il/products/computer-on-modules/cm-qs600/ >> >> Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com> > > Thanks for working on this! > Some minor notes... > > Can we have the subject aligned with other submissions, e.g. > ARM: dts: qcom: ... > ? > >> --- >> v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested >> v3 changes: add board details and keep dts Makefile sorted alphabetically > > [...] > >> new file mode 100644 >> index 0000000..db7cf03 >> --- /dev/null >> +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts >> @@ -0,0 +1,59 @@ > > [...] > >> + eeprom: eeprom@52 { >> + compatible = "atmel,24c128"; > > I believe the above should be 24c02. > And the address is 0x50. Also, atmel is not the only vendor for the eeprom chips we use, so I think at24 instead of atmel will do better here. > >> + reg = <0x52>; >> + pagesize = <32>; > > pagesize is 16. > > [...] > > Apart from the eeprom stuff above: > > Acked-by: Igor Grinberg <grinberg@compulab.co.il> >
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index aaa1a68..3243722 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -339,6 +339,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += orion5x-lacie-d2-network.dtb \ orion5x-rd88f5182-nas.dtb dtb-$(CONFIG_ARCH_PRIMA2) += prima2-evb.dtb dtb-$(CONFIG_ARCH_QCOM) += \ + qcom-apq8064-cm-qs600.dtb \ qcom-apq8064-ifc6410.dtb \ qcom-apq8074-dragonboard.dtb \ qcom-apq8084-ifc6540.dtb \aaaaaa diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts new file mode 100644 index 0000000..db7cf03 --- /dev/null +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts @@ -0,0 +1,59 @@ +#include "qcom-apq8064-v2.0.dtsi" + +/ { + model = "CompuLab CM-QS600"; + compatible = "qcom,apq8064-cm-qs600", "qcom,apq8064"; + + soc { + pinctrl@800000 { + i2c1_pins: i2c1 { + mux { + pins = "gpio20", "gpio21"; + function = "gsbi1"; + }; + }; + }; + + gsbi@12440000 { + status = "okay"; + qcom,mode = <GSBI_PROT_I2C>; + + i2c@12460000 { + status = "okay"; + clock-frequency = <200000>; + pinctrl-0 = <&i2c1_pins>; + pinctrl-names = "default"; + + eeprom: eeprom@52 { + compatible = "atmel,24c128"; + reg = <0x52>; + pagesize = <32>; + }; + }; + }; + + gsbi@16600000 { + status = "ok"; + qcom,mode = <GSBI_PROT_I2C_UART>; + serial@16640000 { + status = "ok"; + }; + }; + + amba { + /* eMMC */ + sdcc1: sdcc@12400000 { + status = "okay"; + }; + + /* External micro SD card */ + sdcc3: sdcc@12180000 { + status = "okay"; + }; + /* WLAN */ + sdcc4: sdcc@121c0000 { + status = "okay"; + }; + }; + }; +};
CM-QS600 is a APQ8064 based computer on module. The details are available at http://compulab.co.il/products/computer-on-modules/cm-qs600/ Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com> --- v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested v3 changes: add board details and keep dts Makefile sorted alphabetically arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 59 +++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+) create mode 100644 arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts