| Message ID | 1412057659-19483-1-git-send-email-mark.yao@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 30, 2014 at 02:14:19PM +0800, Mark Yao wrote: > From: Mark yao <mark.yao@rock-chips.com> > > This add a display subsystem comprise the all display interface nodes. > > Signed-off-by: Mark Yao <mark.yao@rock-chips.com> > Signed-off-by: Daniel Kurtz <djkurtz@chromium.org> > Acked-by: Daniel Vetter <daniel@ffwll.ch> > Reviewed-by: Rob Clark <robdclark@gmail.com> Just a quick clarification: My ack was only about the drm driver itself, I try really hard to stay away from DT insanity ;-) So please drop my ack from these two patches. Aside: DT patches need to go through a special process and you must cc dt maintainers and mailing lists. Your patch seems to lack this, which afaiui is a blocker for merging the driver. Thanks, Daniel > --- > Changes in v2: > - add DRM master device node to list all display nodes that comprise > the graphics subsystem. > > Changes in v3: None > > Changes in v4: None > > Changes in v5: None > > Changes in v6: None > > Changes in v7: None > > Changes in v8: None > > .../devicetree/bindings/video/rockchip-drm.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/rockchip-drm.txt > > diff --git a/Documentation/devicetree/bindings/video/rockchip-drm.txt b/Documentation/devicetree/bindings/video/rockchip-drm.txt > new file mode 100644 > index 0000000..7fff582 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/rockchip-drm.txt > @@ -0,0 +1,19 @@ > +Rockchip DRM master device > +================================ > + > +The Rockchip DRM master device is a virtual device needed to list all > +vop devices or other display interface nodes that comprise the > +graphics subsystem. > + > +Required properties: > +- compatible: Should be "rockchip,display-subsystem" > +- ports: Should contain a list of phandles pointing to display interface port > + of vop devices. vop definitions as defined in > + Documentation/devicetree/bindings/video/rockchip-vop.txt > + > +example: > + > +display-subsystem { > + compatible = "rockchip,display-subsystem"; > + ports = <&vopl_out>, <&vopb_out>; > +}; > -- > 1.7.9.5 > >
Am Dienstag, 30. September 2014, 10:10:20 schrieb Daniel Vetter: > On Tue, Sep 30, 2014 at 02:14:19PM +0800, Mark Yao wrote: > > From: Mark yao <mark.yao@rock-chips.com> > > > > This add a display subsystem comprise the all display interface nodes. > > > > Signed-off-by: Mark Yao <mark.yao@rock-chips.com> > > Signed-off-by: Daniel Kurtz <djkurtz@chromium.org> > > Acked-by: Daniel Vetter <daniel@ffwll.ch> > > Reviewed-by: Rob Clark <robdclark@gmail.com> > > Just a quick clarification: My ack was only about the drm driver itself, I > try really hard to stay away from DT insanity ;-) So please drop my ack > from these two patches. > > Aside: DT patches need to go through a special process and you must cc dt > maintainers and mailing lists. Your patch seems to lack this, which afaiui > is a blocker for merging the driver. Looking at the recipients I see the dt list (devicetree@vger.kernel.org) as well as the dt maintainers (Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell and Kumar Gala) listed there. So from this side it should be fine Heiko
On 2014?09?30? 16:10, Daniel Vetter wrote: > On Tue, Sep 30, 2014 at 02:14:19PM +0800, Mark Yao wrote: >> From: Mark yao <mark.yao@rock-chips.com> >> >> This add a display subsystem comprise the all display interface nodes. >> >> Signed-off-by: Mark Yao <mark.yao@rock-chips.com> >> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org> >> Acked-by: Daniel Vetter <daniel@ffwll.ch> >> Reviewed-by: Rob Clark <robdclark@gmail.com> > Just a quick clarification: My ack was only about the drm driver itself, I > try really hard to stay away from DT insanity ;-) So please drop my ack > from these two patches. > > Aside: DT patches need to go through a special process and you must cc dt > maintainers and mailing lists. Your patch seems to lack this, which afaiui > is a blocker for merging the driver. > > Thanks, Daniel Oh, I'm sorry, I will drop it soon. >> --- >> Changes in v2: >> - add DRM master device node to list all display nodes that comprise >> the graphics subsystem. >> >> Changes in v3: None >> >> Changes in v4: None >> >> Changes in v5: None >> >> Changes in v6: None >> >> Changes in v7: None >> >> Changes in v8: None >> >> .../devicetree/bindings/video/rockchip-drm.txt | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/video/rockchip-drm.txt >> >> diff --git a/Documentation/devicetree/bindings/video/rockchip-drm.txt b/Documentation/devicetree/bindings/video/rockchip-drm.txt >> new file mode 100644 >> index 0000000..7fff582 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/video/rockchip-drm.txt >> @@ -0,0 +1,19 @@ >> +Rockchip DRM master device >> +================================ >> + >> +The Rockchip DRM master device is a virtual device needed to list all >> +vop devices or other display interface nodes that comprise the >> +graphics subsystem. >> + >> +Required properties: >> +- compatible: Should be "rockchip,display-subsystem" >> +- ports: Should contain a list of phandles pointing to display interface port >> + of vop devices. vop definitions as defined in >> + Documentation/devicetree/bindings/video/rockchip-vop.txt >> + >> +example: >> + >> +display-subsystem { >> + compatible = "rockchip,display-subsystem"; >> + ports = <&vopl_out>, <&vopb_out>; >> +}; >> -- >> 1.7.9.5 >> >>
On Tue, Sep 30, 2014 at 10:10:20AM +0200, Daniel Vetter wrote: > On Tue, Sep 30, 2014 at 02:14:19PM +0800, Mark Yao wrote: > > From: Mark yao <mark.yao@rock-chips.com> > > > > This add a display subsystem comprise the all display interface nodes. > > > > Signed-off-by: Mark Yao <mark.yao@rock-chips.com> > > Signed-off-by: Daniel Kurtz <djkurtz@chromium.org> > > Acked-by: Daniel Vetter <daniel@ffwll.ch> > > Reviewed-by: Rob Clark <robdclark@gmail.com> > > Just a quick clarification: My ack was only about the drm driver itself, I > try really hard to stay away from DT insanity ;-) So please drop my ack > from these two patches. > > Aside: DT patches need to go through a special process and you must cc dt > maintainers and mailing lists. Your patch seems to lack this, which afaiui > is a blocker for merging the driver. With coffee working I've now noticed that DT people are on cc ;-) I guess you need to poke them for review, since the drm/driver side looks ready. Would be sad if this would miss 3.18 imo. -Daniel
diff --git a/Documentation/devicetree/bindings/video/rockchip-drm.txt b/Documentation/devicetree/bindings/video/rockchip-drm.txt new file mode 100644 index 0000000..7fff582 --- /dev/null +++ b/Documentation/devicetree/bindings/video/rockchip-drm.txt @@ -0,0 +1,19 @@ +Rockchip DRM master device +================================ + +The Rockchip DRM master device is a virtual device needed to list all +vop devices or other display interface nodes that comprise the +graphics subsystem. + +Required properties: +- compatible: Should be "rockchip,display-subsystem" +- ports: Should contain a list of phandles pointing to display interface port + of vop devices. vop definitions as defined in + Documentation/devicetree/bindings/video/rockchip-vop.txt + +example: + +display-subsystem { + compatible = "rockchip,display-subsystem"; + ports = <&vopl_out>, <&vopb_out>; +};