| Message ID | 1251845630-18072-1-git-send-email-santiago.nunez@ridgerun.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 new phone: 301-407-9583 Old Phone : 301-515-3736 (will be deprecated) email: m-karicheri2@ti.com >-----Original Message----- >From: santiago.nunez@ridgerun.com [mailto:santiago.nunez@ridgerun.com] >Sent: Tuesday, September 01, 2009 6:54 PM >To: Karicheri, Muralidharan >Cc: davinci-linux-open-source@linux.davincidsp.com; >todd.fischer@ridgerun.com; diego.dompe@ridgerun.com; >clark.becker@ridgerun.com; Narnakaje, Snehaprabha; Santiago Nunez-Corrales >Subject: [PATCH 3/6 v3] Updated Support for TVP7002 in VPFE > >From: Santiago Nunez-Corrales <santiago.nunez@ridgerun.com> > >This patch adds support for TVP7002 in the DM365 VPFE inteface. >Cleaned up code. > >Signed-off-by: Santiago Nunez-Corrales <santiago.nunez@ridgerun.com> >--- > drivers/media/video/davinci/vpfe_capture.c | 12 ++++++++++-- > 1 files changed, 10 insertions(+), 2 deletions(-) > >diff --git a/drivers/media/video/davinci/vpfe_capture.c >b/drivers/media/video/davinci/vpfe_capture.c >index 2a4a05a..446e897 100644 >--- a/drivers/media/video/davinci/vpfe_capture.c >+++ b/drivers/media/video/davinci/vpfe_capture.c >@@ -140,8 +140,16 @@ static DEFINE_MUTEX(ccdc_lock); > static struct ccdc_config *ccdc_cfg; > > const struct vpfe_standard vpfe_standards[] = { >- {V4L2_STD_525_60, 720, 480, {11, 10}, 1}, >- {V4L2_STD_625_50, 720, 576, {54, 59}, 1}, Why remove these? You need to remove below 525I and 625I. Looks like pixel aspect ratio of 1080i & 720p HD formats are square. So you need to use 1/1 for these. Where did you get this as 12/10? I am referring the following... http://lurkertech.com/lg/pixelaspect/. Not sure which are the references for this article and hence it's authenticity. >+ {V4L2_STD_525I_60, 720, 480, {11, 10}, 1}, >+ {V4L2_STD_525P_60, 720, 480, {11, 10}, 0}, >+ {V4L2_STD_625I_50, 720, 576, {54, 59}, 1}, >+ {V4L2_STD_625P_50, 720, 576, {54, 59}, 0}, >+ {V4L2_STD_720P_50, 1280, 720, {12, 10}, 0}, >+ {V4L2_STD_720P_60, 1280, 720, {12, 10}, 0}, >+ {V4L2_STD_1080I_50, 1920, 1080, {12, 10}, 1}, >+ {V4L2_STD_1080I_60, 1920, 1080, {12, 10}, 1}, >+ {V4L2_STD_1080P_50, 1920, 1080, {12, 10}, 0}, >+ {V4L2_STD_1080P_60, 1920, 1080, {12, 10}, 0}, > }; > > /* Used when raw Bayer image from ccdc is directly captured to SDRAM */ >-- >1.6.0.4 >
diff --git a/drivers/media/video/davinci/vpfe_capture.c b/drivers/media/video/davinci/vpfe_capture.c index 2a4a05a..446e897 100644 --- a/drivers/media/video/davinci/vpfe_capture.c +++ b/drivers/media/video/davinci/vpfe_capture.c @@ -140,8 +140,16 @@ static DEFINE_MUTEX(ccdc_lock); static struct ccdc_config *ccdc_cfg; const struct vpfe_standard vpfe_standards[] = { - {V4L2_STD_525_60, 720, 480, {11, 10}, 1}, - {V4L2_STD_625_50, 720, 576, {54, 59}, 1}, + {V4L2_STD_525I_60, 720, 480, {11, 10}, 1}, + {V4L2_STD_525P_60, 720, 480, {11, 10}, 0}, + {V4L2_STD_625I_50, 720, 576, {54, 59}, 1}, + {V4L2_STD_625P_50, 720, 576, {54, 59}, 0}, + {V4L2_STD_720P_50, 1280, 720, {12, 10}, 0}, + {V4L2_STD_720P_60, 1280, 720, {12, 10}, 0}, + {V4L2_STD_1080I_50, 1920, 1080, {12, 10}, 1}, + {V4L2_STD_1080I_60, 1920, 1080, {12, 10}, 1}, + {V4L2_STD_1080P_50, 1920, 1080, {12, 10}, 0}, + {V4L2_STD_1080P_60, 1920, 1080, {12, 10}, 0}, }; /* Used when raw Bayer image from ccdc is directly captured to SDRAM */