| Message ID | 1412237073-1288-2-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On 10/2/2014 12:04 PM, Yoshihiro Shimoda wrote: > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index 2380fd5..fd9fc37 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -1314,4 +1314,14 @@ > ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; }; > }; > }; > + > + hsusb: usb@e6590000 { > + compatible = "renesas,usbhs-r8a7790"; > + reg = <0 0xe6590000 0 0x100>; > + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>; I don't see where are you handling this prop in the driver... > + renesas,buswait_bwait = <4>; This prop is named "renesas,buswait" now. >" + phys = <&usb0 1>; > + phy-names = "usb"; > + }; > }; WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/2/2014 12:04 PM, Yoshihiro Shimoda wrote: > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index 2380fd5..fd9fc37 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -1314,4 +1314,14 @@ > ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; }; > }; > }; > + > + hsusb: usb@e6590000 { > + compatible = "renesas,usbhs-r8a7790"; > + reg = <0 0xe6590000 0 0x100>; > + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>; > + renesas,buswait_bwait = <4>; > + phys = <&usb0 1>; > + phy-names = "usb"; You need. status = "disabled"; since you're enabling the device node in the board .dts. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. (2014/10/02 18:58), Sergei Shtylyov wrote: > On 10/2/2014 12:04 PM, Yoshihiro Shimoda wrote: > >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> --- >> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) > >> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi >> index 2380fd5..fd9fc37 100644 >> --- a/arch/arm/boot/dts/r8a7790.dtsi >> +++ b/arch/arm/boot/dts/r8a7790.dtsi >> @@ -1314,4 +1314,14 @@ >> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; }; >> }; >> }; >> + >> + hsusb: usb@e6590000 { >> + compatible = "renesas,usbhs-r8a7790"; >> + reg = <0 0xe6590000 0 0x100>; >> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>; > > I don't see where are you handling this prop in the driver... Thank you for the point. I misunderstood this prop. Since the driver is using pm_runtime functions, I thought that this device node needs this prop. So, I will remove this. And, I will also modify the Documentation. >> + renesas,buswait_bwait = <4>; > > This prop is named "renesas,buswait" now. Thank you for the point. I will fix it. Best regards, Yoshihiro Shimoda >> " + phys = <&usb0 1>; >> + phy-names = "usb"; >> + }; >> }; > > WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. (2014/10/02 18:59), Sergei Shtylyov wrote: > On 10/2/2014 12:04 PM, Yoshihiro Shimoda wrote: > >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> --- >> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) > >> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi >> index 2380fd5..fd9fc37 100644 >> --- a/arch/arm/boot/dts/r8a7790.dtsi >> +++ b/arch/arm/boot/dts/r8a7790.dtsi >> @@ -1314,4 +1314,14 @@ >> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; }; >> }; >> }; >> + >> + hsusb: usb@e6590000 { >> + compatible = "renesas,usbhs-r8a7790"; >> + reg = <0 0xe6590000 0 0x100>; >> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>; >> + renesas,buswait_bwait = <4>; >> + phys = <&usb0 1>; >> + phy-names = "usb"; > > You need. > > status = "disabled"; > > since you're enabling the device node in the board .dts. Thank you for the point again. I will add this. Best regards, Yoshihiro Shimoda > WBR, Sergei > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 10/02/2014 03:40 PM, Yoshihiro Shimoda wrote: >>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >>> --- >>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi >>> index 2380fd5..fd9fc37 100644 >>> --- a/arch/arm/boot/dts/r8a7790.dtsi >>> +++ b/arch/arm/boot/dts/r8a7790.dtsi >>> @@ -1314,4 +1314,14 @@ >>> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; }; >>> }; >>> }; >>> + >>> + hsusb: usb@e6590000 { >>> + compatible = "renesas,usbhs-r8a7790"; >>> + reg = <0 0xe6590000 0 0x100>; >>> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>; >>> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>; >> I don't see where are you handling this prop in the driver... > Thank you for the point. I misunderstood this prop. > Since the driver is using pm_runtime functions, I thought that > this device node needs this prop. Ah, I've overlooked the RPM related code. No need to remove the prop then. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote: > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index 2380fd5..fd9fc37 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -1314,4 +1314,14 @@ > ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; }; > }; > }; > + > + hsusb: usb@e6590000 { > + compatible = "renesas,usbhs-r8a7790"; > + reg = <0 0xe6590000 0 0x100>; > + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>; > + renesas,buswait_bwait = <4>; > + phys = <&usb0 1>; > + phy-names = "usb"; > + }; I think the better placement would be prior to USB PHY node, not at the end of the file. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello.
On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
The subject has "shimobile" instead of "shmobile" on both this and R8A7791
patch. And capitalize "arm:" please on all the patches.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. (2014/10/03 23:34), Sergei Shtylyov wrote: > Hello. > > On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote: > >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > The subject has "shimobile" instead of "shmobile" on both this and R8A7791 > patch. And capitalize "arm:" please on all the patches. Thank you for the point. I will fix it. Best regards, Yoshihiro Shimoda > WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index 2380fd5..fd9fc37 100644 --- a/arch/arm/boot/dts/r8a7790.dtsi +++ b/arch/arm/boot/dts/r8a7790.dtsi @@ -1314,4 +1314,14 @@ ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; }; }; }; + + hsusb: usb@e6590000 { + compatible = "renesas,usbhs-r8a7790"; + reg = <0 0xe6590000 0 0x100>; + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>; + renesas,buswait_bwait = <4>; + phys = <&usb0 1>; + phy-names = "usb"; + }; };
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)