diff mbox

Fix coalesced interrupt reporting in IOAPIC

Message ID 20090903091034.GB30093@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Gleb Natapov Sept. 3, 2009, 9:10 a.m. UTC 
This bug was introduced by b4a2f5e723e4f7df46731106faf9e2405673c073

Signed-off-by: Gleb Natapov <gleb@redhat.com>
--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Marcelo Tosatti Sept. 3, 2009, 5:31 p.m. UTC | #1 
On Thu, Sep 03, 2009 at 12:10:34PM +0300, Gleb Natapov wrote:
> This bug was introduced by b4a2f5e723e4f7df46731106faf9e2405673c073
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
> index e9de458..38a2d20 100644
> --- a/virt/kvm/ioapic.c
> +++ b/virt/kvm/ioapic.c
> @@ -194,6 +194,8 @@ int kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq, int level)
>  			if ((edge && old_irr != ioapic->irr) ||
>  			    (!edge && !entry.fields.remote_irr))
>  				ret = ioapic_service(ioapic, irq);
> +			else
> +				ret = 0; /* report coalesced interrupt */
>  		}
>  		trace_kvm_ioapic_set_irq(entry.bits, irq, ret == 0);
>  	}
> --
> 			Gleb.

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
index e9de458..38a2d20 100644
--- a/virt/kvm/ioapic.c
+++ b/virt/kvm/ioapic.c
@@ -194,6 +194,8 @@  int kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq, int level)
 			if ((edge && old_irr != ioapic->irr) ||
 			    (!edge && !entry.fields.remote_irr))
 				ret = ioapic_service(ioapic, irq);
+			else
+				ret = 0; /* report coalesced interrupt */
 		}
 		trace_kvm_ioapic_set_irq(entry.bits, irq, ret == 0);
 	}