| Message ID | 1413042040-28222-7-git-send-email-vinod.koul@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 11/10/2014 17:40, Vinod Koul : > The drivers should use dmaengine_terminate_all() API instead of > accessing the device_control which will be deprecated soon > > Signed-off-by: Vinod Koul <vinod.koul@intel.com> sure: Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Thanks Vinod. Bye, > --- > drivers/spi/spi-atmel.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 113c83f..649dcb5 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -482,11 +482,9 @@ error: > static void atmel_spi_stop_dma(struct atmel_spi *as) > { > if (as->dma.chan_rx) > - as->dma.chan_rx->device->device_control(as->dma.chan_rx, > - DMA_TERMINATE_ALL, 0); > + dmaengine_terminate_all(as->dma.chan_rx); > if (as->dma.chan_tx) > - as->dma.chan_tx->device->device_control(as->dma.chan_tx, > - DMA_TERMINATE_ALL, 0); > + dmaengine_terminate_all(as->dma.chan_tx); > } > > static void atmel_spi_release_dma(struct atmel_spi *as) >
On Sat, Oct 11, 2014 at 09:10:35PM +0530, Vinod Koul wrote: > The drivers should use dmaengine_terminate_all() API instead of > accessing the device_control which will be deprecated soon Applied, thanks.
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c index 113c83f..649dcb5 100644 --- a/drivers/spi/spi-atmel.c +++ b/drivers/spi/spi-atmel.c @@ -482,11 +482,9 @@ error: static void atmel_spi_stop_dma(struct atmel_spi *as) { if (as->dma.chan_rx) - as->dma.chan_rx->device->device_control(as->dma.chan_rx, - DMA_TERMINATE_ALL, 0); + dmaengine_terminate_all(as->dma.chan_rx); if (as->dma.chan_tx) - as->dma.chan_tx->device->device_control(as->dma.chan_tx, - DMA_TERMINATE_ALL, 0); + dmaengine_terminate_all(as->dma.chan_tx); } static void atmel_spi_release_dma(struct atmel_spi *as)
The drivers should use dmaengine_terminate_all() API instead of accessing the device_control which will be deprecated soon Signed-off-by: Vinod Koul <vinod.koul@intel.com> --- drivers/spi/spi-atmel.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)