| Message ID | 1412852099-23099-1-git-send-email-riku.voipio@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Looks good. Andrew, can you pick this change up via your tree? Acked-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com> On 09.10.2014 12:54, Riku Voipio wrote: > Following up the arm testing of gcov, turns out gcov on ARM64 > works fine as well. Only change needed is adding ARM64 to Kconfig > depends. > > Tested with qemu and mach-virt > > Signed-off-by: Riku Voipio <riku.voipio@linaro.org> > --- > kernel/gcov/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig > index cf66c5c..3b74087 100644 > --- a/kernel/gcov/Kconfig > +++ b/kernel/gcov/Kconfig > @@ -35,7 +35,7 @@ config GCOV_KERNEL > config GCOV_PROFILE_ALL > bool "Profile entire Kernel" > depends on GCOV_KERNEL > - depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM > + depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64 > default n > ---help--- > This options activates profiling for the entire kernel. >
On Thu, 09 Oct 2014 16:00:20 +0200 Peter Oberparleiter <oberpar@linux.vnet.ibm.com> wrote: > Looks good. Andrew, can you pick this change up via your tree? > Sure. > > On 09.10.2014 12:54, Riku Voipio wrote: > > Following up the arm testing of gcov, turns out gcov on ARM64 > > works fine as well. Only change needed is adding ARM64 to Kconfig > > depends. > > > > Tested with qemu and mach-virt > > > > Signed-off-by: Riku Voipio <riku.voipio@linaro.org> > > --- > > kernel/gcov/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig > > index cf66c5c..3b74087 100644 > > --- a/kernel/gcov/Kconfig > > +++ b/kernel/gcov/Kconfig > > @@ -35,7 +35,7 @@ config GCOV_KERNEL > > config GCOV_PROFILE_ALL > > bool "Profile entire Kernel" > > depends on GCOV_KERNEL > > - depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM > > + depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64 > > default n > > ---help--- > > This options activates profiling for the entire kernel. gcov is doing this the wrong way. There should be a `select GCOV_PROFILE_ALL' in each arch/*/Kconfig. (But pleeeeeeze not at the end of the list! That's the perfect way of maximizing patch conflicts, but nobody seems to understand this)
Hi Andrew, On Tue, 14 Oct 2014 14:40:48 -0700 Andrew Morton <akpm@linux-foundation.org> wrote: > > > > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig > > > index cf66c5c..3b74087 100644 > > > --- a/kernel/gcov/Kconfig > > > +++ b/kernel/gcov/Kconfig > > > @@ -35,7 +35,7 @@ config GCOV_KERNEL > > > config GCOV_PROFILE_ALL > > > bool "Profile entire Kernel" > > > depends on GCOV_KERNEL > > > - depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM > > > + depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64 > > > default n > > > ---help--- > > > This options activates profiling for the entire kernel. > > gcov is doing this the wrong way. There should be a `select > GCOV_PROFILE_ALL' in each arch/*/Kconfig. What they should actually do is select (say) ARCH_HAS_GCOV_PROFILE_ALL and then GCOV_PROFILE_ALL should depend on that.
diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig index cf66c5c..3b74087 100644 --- a/kernel/gcov/Kconfig +++ b/kernel/gcov/Kconfig @@ -35,7 +35,7 @@ config GCOV_KERNEL config GCOV_PROFILE_ALL bool "Profile entire Kernel" depends on GCOV_KERNEL - depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM + depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64 default n ---help--- This options activates profiling for the entire kernel.
Following up the arm testing of gcov, turns out gcov on ARM64 works fine as well. Only change needed is adding ARM64 to Kconfig depends. Tested with qemu and mach-virt Signed-off-by: Riku Voipio <riku.voipio@linaro.org> --- kernel/gcov/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)