| Message ID | 1413445197-22304-1-git-send-email-vinod.koul@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Oct 16, 2014 at 11:42:09AM +0300, Andy Shevchenko wrote: > On Thu, 2014-10-16 at 13:09 +0530, Vinod Koul wrote: > > The atmel serial driver uses dmaengine APIs but never included the dmaengine > > header as it was getting inculded thru one of driver headers. > > > > commit 3d588f83e4d6a5230d9094b97d38621cbaa9a972 - "dmaengine: dw: split > > dma-dw.h to platform and private parts" broke this as it moved headers > > around. Fix this by doing the right thing to include the dmaengine header > > > > Thanks, I just sent similar idea to Fengguang and you. > > I don't know if it would be a stable material. If so, it would be nice > to add: > > Fixes: 08f738be88bb (serial: at91: add tx dma support) > Cc: stable@vger.kernel.org Fixes yes, but am not too keen on marking this stable as it wont show up unless we have 3d588f8
On Thu, 2014-10-16 at 13:09 +0530, Vinod Koul wrote: > The atmel serial driver uses dmaengine APIs but never included the dmaengine > header as it was getting inculded thru one of driver headers. > > commit 3d588f83e4d6a5230d9094b97d38621cbaa9a972 - "dmaengine: dw: split > dma-dw.h to platform and private parts" broke this as it moved headers > around. Fix this by doing the right thing to include the dmaengine header > Thanks, I just sent similar idea to Fengguang and you. I don't know if it would be a stable material. If so, it would be nice to add: Fixes: 08f738be88bb (serial: at91: add tx dma support) Cc: stable@vger.kernel.org > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: Vinod Koul <vinod.koul@intel.com> > --- > Greg, since this is path which broke this is sitting in my next, would it be > okay to carry this thru dmaengine tree as get it merged in current window. > Planning to send pull request in day or so to Linus > > drivers/tty/serial/atmel_serial.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index d7d4584..edde3ec 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -37,6 +37,7 @@ > #include <linux/of_device.h> > #include <linux/of_gpio.h> > #include <linux/dma-mapping.h> > +#include <linux/dmaengine.h> > #include <linux/atmel_pdc.h> > #include <linux/atmel_serial.h> > #include <linux/uaccess.h>
On Thu, Oct 16, 2014 at 11:10:59AM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 16, 2014 at 01:09:57PM +0530, Vinod Koul wrote: > > The atmel serial driver uses dmaengine APIs but never included the dmaengine > > header as it was getting inculded thru one of driver headers. > > > > commit 3d588f83e4d6a5230d9094b97d38621cbaa9a972 - "dmaengine: dw: split > > dma-dw.h to platform and private parts" broke this as it moved headers > > around. Fix this by doing the right thing to include the dmaengine header > > > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > > Signed-off-by: Vinod Koul <vinod.koul@intel.com> > > --- > > Greg, since this is path which broke this is sitting in my next, would it be > > okay to carry this thru dmaengine tree as get it merged in current window. > > Planning to send pull request in day or so to Linus > > Sure, that's fine with me: > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Thanks :) Applied, and pushed now
On Thu, Oct 16, 2014 at 01:09:57PM +0530, Vinod Koul wrote: > The atmel serial driver uses dmaengine APIs but never included the dmaengine > header as it was getting inculded thru one of driver headers. > > commit 3d588f83e4d6a5230d9094b97d38621cbaa9a972 - "dmaengine: dw: split > dma-dw.h to platform and private parts" broke this as it moved headers > around. Fix this by doing the right thing to include the dmaengine header > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: Vinod Koul <vinod.koul@intel.com> > --- > Greg, since this is path which broke this is sitting in my next, would it be > okay to carry this thru dmaengine tree as get it merged in current window. > Planning to send pull request in day or so to Linus Sure, that's fine with me: Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 16/10/2014 10:56, Vinod Koul : > On Thu, Oct 16, 2014 at 11:10:59AM +0200, Greg Kroah-Hartman wrote: >> On Thu, Oct 16, 2014 at 01:09:57PM +0530, Vinod Koul wrote: >>> The atmel serial driver uses dmaengine APIs but never included the dmaengine >>> header as it was getting inculded thru one of driver headers. >>> >>> commit 3d588f83e4d6a5230d9094b97d38621cbaa9a972 - "dmaengine: dw: split >>> dma-dw.h to platform and private parts" broke this as it moved headers >>> around. Fix this by doing the right thing to include the dmaengine header >>> >>> Reported-by: kbuild test robot <fengguang.wu@intel.com> >>> Signed-off-by: Vinod Koul <vinod.koul@intel.com> >>> --- >>> Greg, since this is path which broke this is sitting in my next, would it be >>> okay to carry this thru dmaengine tree as get it merged in current window. >>> Planning to send pull request in day or so to Linus >> >> Sure, that's fine with me: >> >> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Thanks :) > > Applied, and pushed now Vinod, thanks a lot for having handled this issue. For the record even if it's too late: Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Bye,
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c index d7d4584..edde3ec 100644 --- a/drivers/tty/serial/atmel_serial.c +++ b/drivers/tty/serial/atmel_serial.c @@ -37,6 +37,7 @@ #include <linux/of_device.h> #include <linux/of_gpio.h> #include <linux/dma-mapping.h> +#include <linux/dmaengine.h> #include <linux/atmel_pdc.h> #include <linux/atmel_serial.h> #include <linux/uaccess.h>
The atmel serial driver uses dmaengine APIs but never included the dmaengine header as it was getting inculded thru one of driver headers. commit 3d588f83e4d6a5230d9094b97d38621cbaa9a972 - "dmaengine: dw: split dma-dw.h to platform and private parts" broke this as it moved headers around. Fix this by doing the right thing to include the dmaengine header Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com> --- Greg, since this is path which broke this is sitting in my next, would it be okay to carry this thru dmaengine tree as get it merged in current window. Planning to send pull request in day or so to Linus drivers/tty/serial/atmel_serial.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)