diff mbox

ASoC: rt5677: add build dependency to spi

Message ID 1413572202-18646-1-git-send-email-anatol.pomozov@gmail.com (mailing list archive)
State Accepted
Commit ac884fc47b7750b1e7eaf04f0236610c84ceee54
Headers show

Commit Message

Anatol Pomozov Oct. 17, 2014, 6:56 p.m. UTC 
Since 9cb715a9d4c the codec has a hardcoded dependency to spi.
Add this dependency to Kconfig. It fixes buildbot compilation failure:

   sound/built-in.o: In function `spi_write':
>> rt5677-spi.c:(.text+0x8265f): undefined reference to `spi_sync'
   sound/built-in.o: In function `rt5677_spi_driver_init':
>> rt5677-spi.c:(.init.text+0x17db): undefined reference to `spi_register_driver'

Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com>
---
 sound/soc/codecs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Oder Chiou Oct. 18, 2014, 3:15 a.m. UTC | #1 
> -----Original Message-----
> From: Anatol Pomozov [mailto:anatol.pomozov@gmail.com]
> Sent: Saturday, October 18, 2014 2:57 AM
> To: broonie@kernel.org
> Cc: Oder Chiou; alsa-devel@alsa-project.org; Anatol Pomozov
> Subject: [PATCH] ASoC: rt5677: add build dependency to spi
> 
> Since 9cb715a9d4c the codec has a hardcoded dependency to spi.
> Add this dependency to Kconfig. It fixes buildbot compilation failure:
> 
>    sound/built-in.o: In function `spi_write':
> >> rt5677-spi.c:(.text+0x8265f): undefined reference to `spi_sync'
>    sound/built-in.o: In function `rt5677_spi_driver_init':
> >> rt5677-spi.c:(.init.text+0x17db): undefined reference to `spi_register_driver'
> 
> Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com>

Oder Chiou <oder_chiou@realtek.com>
Mark Brown Oct. 20, 2014, 10:03 a.m. UTC | #2 
On Fri, Oct 17, 2014 at 11:56:42AM -0700, Anatol Pomozov wrote:
> Since 9cb715a9d4c the codec has a hardcoded dependency to spi.
> Add this dependency to Kconfig. It fixes buildbot compilation failure:

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 8838838e..1ff565e 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -81,7 +81,7 @@  config SND_SOC_ALL_CODECS
 	select SND_SOC_RT5645 if I2C
 	select SND_SOC_RT5651 if I2C
 	select SND_SOC_RT5670 if I2C
-	select SND_SOC_RT5677 if I2C
+	select SND_SOC_RT5677 if I2C && SPI_MASTER
 	select SND_SOC_SGTL5000 if I2C
 	select SND_SOC_SI476X if MFD_SI476X_CORE
 	select SND_SOC_SIRF_AUDIO_CODEC