| Message ID | 1414427215-14380-3-git-send-email-romain.perier@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Oct 27, 2014 at 04:26:48PM +0000, Romain Perier wrote: > Signed-off-by: Romain Perier <romain.perier@gmail.com> > --- > drivers/regulator/act8865-regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c > index 76301ed..435aba1 100644 > --- a/drivers/regulator/act8865-regulator.c > +++ b/drivers/regulator/act8865-regulator.c > @@ -365,7 +365,7 @@ static int act8865_pmic_probe(struct i2c_client *client, > return ret; > } > > - if (of_system_has_poweroff_source(dev->of_node)) { > + if (of_is_system_power_controller(dev->of_node)) { so building this driver is broken until this patch ? not very good either. Looks to me you should add of_is_system_power_controller without remove of_system_has_poweroff_source() until all users of that have been converted over.
Am Montag, 27. Oktober 2014, 11:40:22 schrieb Felipe Balbi: > On Mon, Oct 27, 2014 at 04:26:48PM +0000, Romain Perier wrote: > > Signed-off-by: Romain Perier <romain.perier@gmail.com> > > --- > > > > drivers/regulator/act8865-regulator.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/regulator/act8865-regulator.c > > b/drivers/regulator/act8865-regulator.c index 76301ed..435aba1 100644 > > --- a/drivers/regulator/act8865-regulator.c > > +++ b/drivers/regulator/act8865-regulator.c > > @@ -365,7 +365,7 @@ static int act8865_pmic_probe(struct i2c_client > > *client,> > > return ret; > > > > } > > > > - if (of_system_has_poweroff_source(dev->of_node)) { > > + if (of_is_system_power_controller(dev->of_node)) { > > so building this driver is broken until this patch ? not very good > either. > > Looks to me you should add of_is_system_power_controller without remove > of_system_has_poweroff_source() until all users of that have been > converted over. or alternatively fold this change into patch1 to keep the renaming together
diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c index 76301ed..435aba1 100644 --- a/drivers/regulator/act8865-regulator.c +++ b/drivers/regulator/act8865-regulator.c @@ -365,7 +365,7 @@ static int act8865_pmic_probe(struct i2c_client *client, return ret; } - if (of_system_has_poweroff_source(dev->of_node)) { + if (of_is_system_power_controller(dev->of_node)) { if (!pm_power_off) { act8865_i2c_client = client; act8865->off_reg = off_reg;
Signed-off-by: Romain Perier <romain.perier@gmail.com> --- drivers/regulator/act8865-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)