diff mbox

[linux-cifs-client] add info about how to obtain cifs module in cifs mount heleper manpages

Message ID 4a4634330908261355r28738a04gc9460c0561d3d9fb@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shirish Pargaonkar Aug. 26, 2009, 8:55 p.m. UTC
Samba bugzilla bug 5129.  Would something like this added to the
manpages suffice?


 <refsect1>

Comments

Jeff Layton Sept. 8, 2009, 2:04 p.m. UTC | #1
On Tue, 8 Sep 2009 08:26:25 -0500
Shirish Pargaonkar <shirishpargaonkar@gmail.com> wrote:

> Reposting the patch, hope the format looks correct.
> 
> diff --git a/docs-xml/manpages-3/mount.cifs.8.xml
> b/docs-xml/manpages-3/mount.cifs.8.xml

^^^ that's line wrapped

> index 9383f3f..4f775e8 100644
> --- a/docs-xml/manpages-3/mount.cifs.8.xml
> +++ b/docs-xml/manpages-3/mount.cifs.8.xml
> @@ -62,6 +62,14 @@ kernel log.
>  		the mounted resource is unmounted (usually via the umount utility).
>  	</para>
> 
> +	<para>
> +		<emphasis>mount.cifs -V</emphasis> command displays the version of
> cifs mount helper.

^^^^ this doesn't look right
> +	</para>
> +	<para>
> +
> +		<emphasis>modinfo cifs</emphasis> command displays the version of
> cifs module.

^^^^ and this doesn't either

> +	</para>
> +
>  </refsect1>
> 
>  <refsect1>

Your mailer is linewrapping the patches. Are you just pasting them into
it? That generally doesn't work very well. It looks like you're using
git here. Maybe try using git-format-patch and git-send-email to send
the patches.

Rather than resending to the list, send them to yourself until you get
non-munged patches. Verify that they're right by saving off the email
and trying to apply it as a patch to your tree.

When that works right, then send it to the list.
diff mbox

Patch

diff --git a/docs-xml/manpages-3/mount.cifs.8.xml
b/docs-xml/manpages-3/mount.cifs.8.xml
index 9383f3f..4f775e8 100644
--- a/docs-xml/manpages-3/mount.cifs.8.xml
+++ b/docs-xml/manpages-3/mount.cifs.8.xml
@@ -62,6 +62,14 @@  kernel log.
 		the mounted resource is unmounted (usually via the umount utility).
 	</para>

+	<para>
+		<emphasis>mount.cifs -V</emphasis> command displays the version of
cifs mount helper.
+	</para>
+	<para>
+
+		<emphasis>modinfo cifs</emphasis> command displays the version of
cifs module.
+	</para>
+
 </refsect1>