diff mbox

[0/11,RFC] sound DMA support patches

Message ID 87ioj3irrg.wl%kuninori.morimoto.gx@gmail.com (mailing list archive)
State RFC
Headers show

Commit Message

Kuninori Morimoto Oct. 29, 2014, 1:33 a.m. UTC
Hi Laurent again

Thank you for your DMA cyclic work

> > I've pushed my test branch to
> > 
> > 	git://linuxtv.org/pinchartl/fbdev.git dma/audio
> > 
> > It doesn't include support for DMA hardware descriptors yet, as I wanted to 
> > rule out any issue with them.

Unfortunately, it was patch applying magic.
ak4643 is needed under iic2, not iic1.
Can you add attached patch on your dma/audio branch ?

It works for me.
When you use sound on Lager board, you need amixer setting.
And you can use bottom jack of CN17 for sound output.

     / # amixer set "LINEOUT Mixer DACL" on

     /* start sound playback and check DMA interrupt */

     / # aplay /home/xxx.wav &
     / # grep dma /proc/interrupts 
     ...
     352:        103          0          0          0       GIC 352  ec700000.dma-contorller:0
     / # grep dma /proc/interrupts 
     ...
     352:        124          0          0          0       GIC 352  ec700000.dma-contorller:0
     / # grep dma /proc/interrupts 
     ...
     352:        146          0          0          0       GIC 352  ec700000.dma-contorller:0
     / # grep dma /proc/interrupts 
     ...
     352:        195          0          0          0       GIC 352  ec700000.dma-contorller:0
     / # grep dma /proc/interrupts 
     ...
     352:        216          0          0          0       GIC 352  ec700000.dma-contorller:0
     / # grep dma /proc/interrupts 
     ...
     352:        239          0          0          0       GIC 352  ec700000.dma-contorller:0

     /* stop sound playback and check DMA interrupt */

     / # fg
     aplay /home/Calm_16bit_48k.wav
     ^CAborted by signal Interrupt...
     / # grep dma /proc/interrupts 
     ...
     352:        280          0          0          0       GIC 352  ec700000.dma-contorller:0
     / # grep dma /proc/interrupts 
     ...
     352:        280          0          0          0       GIC 352  ec700000.dma-contorller:0

----------------------
----------------------

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Laurent Pinchart Oct. 29, 2014, 2:08 p.m. UTC | #1
Hi Morimoto-san,

On Tuesday 28 October 2014 18:33:38 Kuninori Morimoto wrote:
> Hi Laurent again
> 
> Thank you for your DMA cyclic work
> 
> > > I've pushed my test branch to
> > > 
> > > 	git://linuxtv.org/pinchartl/fbdev.git dma/audio
> > > 
> > > It doesn't include support for DMA hardware descriptors yet, as I wanted
> > > to rule out any issue with them.
> 
> Unfortunately, it was patch applying magic.
> ak4643 is needed under iic2, not iic1.
> Can you add attached patch on your dma/audio branch ?
> 
> It works for me.
> When you use sound on Lager board, you need amixer setting.
> And you can use bottom jack of CN17 for sound output.
> 
>      / # amixer set "LINEOUT Mixer DACL" on

After applying your patch and setting the control I get sound ! I'll now test 
and debug hardware descriptors support.

Thank you for your help.

>      /* start sound playback and check DMA interrupt */
> 
>      / # aplay /home/xxx.wav &
>      / # grep dma /proc/interrupts
>      ...
>      352:        103          0          0          0       GIC 352 
> ec700000.dma-contorller:0 / # grep dma /proc/interrupts
>      ...
>      352:        124          0          0          0       GIC 352 
> ec700000.dma-contorller:0 / # grep dma /proc/interrupts
>      ...
>      352:        146          0          0          0       GIC 352 
> ec700000.dma-contorller:0 / # grep dma /proc/interrupts
>      ...
>      352:        195          0          0          0       GIC 352 
> ec700000.dma-contorller:0 / # grep dma /proc/interrupts
>      ...
>      352:        216          0          0          0       GIC 352 
> ec700000.dma-contorller:0 / # grep dma /proc/interrupts
>      ...
>      352:        239          0          0          0       GIC 352 
> ec700000.dma-contorller:0
> 
>      /* stop sound playback and check DMA interrupt */
> 
>      / # fg
>      aplay /home/Calm_16bit_48k.wav
>      ^CAborted by signal Interrupt...
>      / # grep dma /proc/interrupts
>      ...
>      352:        280          0          0          0       GIC 352 
> ec700000.dma-contorller:0 / # grep dma /proc/interrupts
>      ...
>      352:        280          0          0          0       GIC 352 
> ec700000.dma-contorller:0
> 
> ----------------------
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> b/arch/arm/boot/dts/r8a7790-lager.dts index f891a00..03fe43a 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -409,12 +409,6 @@
>         status = "ok";
>         pinctrl-0 = <&iic1_pins>;
>         pinctrl-names = "default";
> -
> -       ak4643: sound_codec {
> -               compatible = "asahi-kasei,ak4643";
> -               #sound-dai-cells = <0>;
> -               reg = <0x12>;
> -       };
>  };
> 
>  &iic2  {
> @@ -434,6 +428,12 @@
>                         };
>                 };
>         };
> +
> +       ak4643: sound_codec {
> +               compatible = "asahi-kasei,ak4643";
> +               #sound-dai-cells = <0>;
> +               reg = <0x12>;
> +       };
>  };
> 
>  &iic3 {
> ----------------------
Kuninori Morimoto Oct. 30, 2014, 12:07 a.m. UTC | #2
Hi Laurent, Magnus

> > > > I've pushed my test branch to
> > > > 
> > > > 	git://linuxtv.org/pinchartl/fbdev.git dma/audio
> > > > 
> > > > It doesn't include support for DMA hardware descriptors yet, as I wanted
> > > > to rule out any issue with them.
> > 
> > Unfortunately, it was patch applying magic.
> > ak4643 is needed under iic2, not iic1.
> > Can you add attached patch on your dma/audio branch ?
> > 
> > It works for me.
> > When you use sound on Lager board, you need amixer setting.
> > And you can use bottom jack of CN17 for sound output.
> > 
> >      / # amixer set "LINEOUT Mixer DACL" on
> 
> After applying your patch and setting the control I get sound ! I'll now test 
> and debug hardware descriptors support.

Nice !
I thik "normal" cyclic is OK on this driver now.
Are all patches which are required for cyclic posted to ML ?
I'm asking because ...
 - I want to send sound support patch
 - LTSI 3.14 backport want to use it.

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Laurent Pinchart Oct. 30, 2014, 12:46 a.m. UTC | #3
Hi Morimoto-san,

On Wednesday 29 October 2014 17:07:20 Kuninori Morimoto wrote:
> Hi Laurent, Magnus
> 
> >>>> I've pushed my test branch to
> >>>> 
> >>>> 	git://linuxtv.org/pinchartl/fbdev.git dma/audio
> >>>> 
> >>>> It doesn't include support for DMA hardware descriptors yet, as I
> >>>> wanted to rule out any issue with them.
> >> 
> >> Unfortunately, it was patch applying magic.
> >> ak4643 is needed under iic2, not iic1.
> >> Can you add attached patch on your dma/audio branch ?
> >> 
> >> It works for me.
> >> When you use sound on Lager board, you need amixer setting.
> >> And you can use bottom jack of CN17 for sound output.
> >> 
> >>      / # amixer set "LINEOUT Mixer DACL" on
> > 
> > After applying your patch and setting the control I get sound ! I'll now
> > test and debug hardware descriptors support.
> 
> Nice !
> I thik "normal" cyclic is OK on this driver now.
> Are all patches which are required for cyclic posted to ML ?
> I'm asking because ...
>  - I want to send sound support patch
>  - LTSI 3.14 backport want to use it.

I've just send the latest version of the rcar-dmac patches to the dmaengine 
and linux-sh mailing list, CC'ing you. They include hardware descriptor list 
and cyclic transfer support. I've tested them with your audio patches (I've 
just pushed my test branch to git://linuxtv.org/pinchartl/fbdev.git 
dma/audio).
Kuninori Morimoto Oct. 30, 2014, 1:28 a.m. UTC | #4
Hi Laurent

> > I thik "normal" cyclic is OK on this driver now.
> > Are all patches which are required for cyclic posted to ML ?
> > I'm asking because ...
> >  - I want to send sound support patch
> >  - LTSI 3.14 backport want to use it.
> 
> I've just send the latest version of the rcar-dmac patches to the dmaengine 
> and linux-sh mailing list, CC'ing you. They include hardware descriptor list 
> and cyclic transfer support. I've tested them with your audio patches (I've 
> just pushed my test branch to git://linuxtv.org/pinchartl/fbdev.git 
> dma/audio).

Thank you !
I will check it, and will post sound support patches to ML

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index f891a00..03fe43a 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -409,12 +409,6 @@ 
        status = "ok";
        pinctrl-0 = <&iic1_pins>;
        pinctrl-names = "default";
-
-       ak4643: sound_codec {
-               compatible = "asahi-kasei,ak4643";
-               #sound-dai-cells = <0>;
-               reg = <0x12>;
-       };
 };
 
 &iic2  {
@@ -434,6 +428,12 @@ 
                        };
                };
        };
+
+       ak4643: sound_codec {
+               compatible = "asahi-kasei,ak4643";
+               #sound-dai-cells = <0>;
+               reg = <0x12>;
+       };
 };
 
 &iic3 {